Merged
Conversation
frankmcsherry
commented
Mar 13, 2026
Owner
Author
|
Claude did have a recommendation about how to zero-copy hand out slices without iterators. It seems sound, but is a change. Recording for posterity, as it seems easy to adopt at any breaking change moment: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is largely authored by Claude, in which we improve the code gen around decoding
&[u64]data into borrow containers, and then access those containers with minimal numbers of instructions. Various problems were removed from the critical path, and an observation was made that it is valuable to do field projection before callingIndex::get, because once you do this Rust's deterministic error semantics require that each output coordinate be formed at least to the point of checking all panics. Instead, project first then borrow. We verified 4 instructions with a cold bounds test on read when done this way.