Merged
Conversation
…rage DecodedStore is a zero-allocation view into Indexed-encoded data that provides O(1) random access to individual slices. from_store on FromBytes uses it to give each field independent access at its compile-time-known offset, eliminating the iterator dependency chain. Assembly: accessing any field of any tuple width is now 49-54 instructions on the critical path, constant in both k (tuple width) and field position. LLVM fully eliminates unused fields across all type combinators: tuples, Results, Options, Vecs, Strings, and arbitrary nesting. Also adds from_u64s and from_store overrides to all remaining FromBytes impls (Usizes, Isizes, Chars, U128s, I128s, Fixeds, Strides, Empties, Bools, Durations) to ensure no leaf type breaks the optimization chain. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
These are superseded by from_store + DecodedStore which provides random access without iterator overhead. The FromBytes trait now has three methods beyond from_bytes: from_store, element_sizes, and validate. The derive macro generates from_store automatically. Also fixes references to the removed Indexed struct in doc comments. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Written with Claude, this adds a structured form of decoding that does not use iteration, as this proves to be hard to fully elide when not used. The type
DecodedStoreessentially provides random access to slices, and could be generalized in the future with a trait that does something like this (notstd::ops::Index, because the lifetimes would be too short).Claude says: