Make element_sizes return Result, default to Err#80
Merged
frankmcsherry merged 1 commit intomasterfrom Mar 14, 2026
Merged
Conversation
The default element_sizes now returns Err("unimplemented") instead of
silently accepting any byte length. This ensures that validate rejects
data for types that haven't implemented element_sizes, rather than
passing validation and producing garbage from from_store.
Types that override element_sizes push their sizes and return Ok(()).
The derive macro already generates this automatically.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default element_sizes now returns Err("unimplemented") instead of silently accepting any byte length. This ensures that validate rejects data for types that haven't implemented element_sizes, rather than passing validation and producing garbage from from_store.
Types that override element_sizes push their sizes and return Ok(()). The derive macro already generates this automatically.