Merged
Conversation
antiguru
reviewed
Mar 18, 2026
Contributor
antiguru
left a comment
antiguru
left a comment
There was a problem hiding this comment.
Seems fine. One comment on the GH workflow, and there's some noise around imports and line breaks before/after, but up to you to care.
frankmcsherry
commented
Mar 18, 2026
Owner
Author
frankmcsherry
left a comment
frankmcsherry
left a comment
There was a problem hiding this comment.
Full read through, and it's largely all localized changes from std:: to either core:: or alloc::. Those parts seem easy and fine. There's also a wrapper trait for std::io::Write that is able to work around the issue of its error type being system defined, and that also checks out (a thing I contributed! though admittedly was shown by a prior Claude).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I previously put together a
no_stdbranch based on instructions from Claude (but I typed). This time it is Claude largely authoring this, with limited guidance (I pointed out a few things, from the first attempt). Needs to be looked at, but .. it was very mechanical when I did it the other time. I'm .. more confident that Claude will get the details right though. Up to read foremost, and potentially to merge if it all checks out.