Demo a merge batcher that uses the container builder #4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the merge batcher to use a container builder to produce its output. This introduces several interesting behavior and unfortunate code changes:
copy_descructured
for timely stacks :(clear
recycled allocations. This is because in columnar, a clear moves a column from any variant to typed, potentially discarding its allocation. Avoiding the clear call might leave some memory sitting around for a bit longer, but the container builders are used to clearing on re-use, so no problems expected on that side.The PR is in the wrong order, the merge batcher changes should go into master and then the columnar builder should pick up the new interface. But, this is how I started so I'm leaving it as-is until we talk about it.