Conversation
…dn support and dedupe logic this update introduces a more robust and flexible parsing layer for both resolvers and domains, ensuring consistent behavior across inline inputs, file-based inputs, and resolver-name lookups. ### key improvements - added ipaddress-based detection for ipv4 and ipv6 resolvers - implemented resolver name matching via _match_resolver_name() - added support for resolver names stored as str, list, or tuple - improved fallback handling for custom hostnames - added idn → punycode normalization for domain inputs - normalized trailing-dot fqnds - added domain deduplication with order preservation - enhanced error messages for invalid resolver inputs - updated cli to use new smart parsing functions - added tests and readme update ### files modified (2) 1. src/dns_benchmark/core.py — added 5 new parsing and matching methods 2. src/dns_benchmark/cli.py — updated resolver/domain loading to use new apis ### new methods added (5) 1. resolvemanager._match_resolver_name() — flexible resolver-name matcher 2. resolvemanager.parse_resolver_string() — parse comma-separated resolvers 3. resolvemanager.parse_resolvers_input() — smart resolver input detection 4. domainmanager.parse_domain_string() — parse comma-separated domains 5. domainmanager.parse_domains_input() — smart domain input detection
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this update introduces a more robust and flexible parsing layer for both resolvers and domains, ensuring consistent behavior across inline inputs, file-based inputs, and resolver-name lookups.
key improvements
files modified (2)
new methods added (5)