Improve Makefile & fix interpreter version#46
Open
Manu-sh wants to merge 1 commit intofrankovo:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, i tryied to install for my distribution via pip (
pipxon Archlinux) but for some reason the version installed doesn't have the latest changes sodns-benchmark benchmark --resolvers='Cloudflare,Google,Quad9' --domains='ping-eu.ds.on.epicgames.com'say that there is no file.so i cloned the repo and notice 2 possible improvements:
i typed
make, thats throw me an error bc. i should usepipxinstead ofpipon my distro or i should create a virtual env, thus i defined the$(PIP)variable make easier to replace in future if needed (however tests doesn't work well without using a virtualenv because of the following commandpython -m dns_benchmark.cli --helpin test_cli_command[cmd_19] but the command seems fine).the interpreter requirement version in
pyproject.tomlare>=3.9,<3.13and refuse to build, but i changed the upper bound to3.14.3(which is my current version) and seems that works fine too. However i only tested my use-case and i don't know if is possible change the python version without breaking the code, but all tests passes.Probably an upper bound on python version isn't required at all at least for now (?)
Tests
i runned tests with
make testeverything seems fine with python 3.14.3