Skip to content

Unbind relations only when the entity is not recently created #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Unbind relations only when the entity is not recently created #254

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1915242
unbind relations only when the entity is not recently created
i110 Aug 26, 2022
2d63252
use dedicated `$created` property instead of abusing `$wasRecentlyCre…
i110 Aug 26, 2022
9150e4b
or stop calling `moveToNode` would be better
i110 Aug 27, 2022
96953b7
fix
i110 Aug 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/Models/Entity.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,13 @@ class Entity extends Eloquent implements EntityInterface
*/
private $isMoved = false;

/**
* Whether this node is newly created.
*
* @var bool
*/
private $created = false;

/**
* Indicates if the model should soft delete.
*
Expand Down Expand Up @@ -289,6 +296,7 @@ public static function boot()
} elseif (!$entity->exists) {
$entity->position = static::getLatestPosition($entity);
}
$entity->created = false;
});

// When entity is created, the appropriate
Expand All @@ -301,10 +309,11 @@ public static function boot()
$ancestor = $entity->parent_id ?? $descendant;

$entity->closure->insertNode($ancestor, $descendant);
$entity->created = true;
});

static::saved(static function (Entity $entity) {
$parentIdChanged = $entity->isDirty($entity->getParentIdColumn());
$parentIdChanged = !$entity->created && $entity->isDirty($entity->getParentIdColumn());

if ($parentIdChanged || $entity->isDirty($entity->getPositionColumn())) {
$entity->reorderSiblings();
Expand Down