feat: store file content out of tiptap#582
Merged
netchampfaris merged 6 commits intomainfrom Feb 26, 2026
Merged
Conversation
Contributor
Author
|
Now maintains dimensions so that there is no layout shift for users: If the upload fails, other users see: |
Comment on lines
+281
to
+287
| <img v-if="!isVideo" ref="mediaRef" class="rounded-[2px]" :class="!isUploaded && 'opacity-40'" :src="node.attrs.src || fileContent" | ||
| :alt="node.attrs.alt || ''" :width="node.attrs.width" :height="node.attrs.height" | ||
| @click.stop="selectMedia" @load="handleMediaLoaded" /> | ||
| <video v-else ref="mediaRef" class="rounded-[2px]" :class="!isUploaded && 'opacity-40'" :src="node.attrs.src || fileContent" | ||
| :width="node.attrs.width" :height="node.attrs.height" :autoplay="node.attrs.autoplay" | ||
| :loop="node.attrs.loop" :muted="node.attrs.muted" :controls="isUploaded" @click.stop="selectMedia" | ||
| @loadedmetadata="handleMediaLoaded" /> |
Contributor
There was a problem hiding this comment.
no prettier formatting?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stores the base-64 file content locally so that it isn't included in Tiptap structure at all (and by extension,
getHTML).This caused issues where the editor save would fail if an sufficiently large video failed in the upload.
Also improves UX by adding a "re-upload" feature and hiding media controls until successful uploaded.
Screenshots
Normal UX for current user:
Looks like this for other users:
