Skip to content

fix(organizational-chart): show empty state when no data is available #4024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
krishna-254 wants to merge 2 commits into
base: develop
Choose a base branch
from
+118 −16
Open

fix(organizational-chart): show empty state when no data is available #4024

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b7f006b
fix(organizational-chart): show empty state when no data is available
krishna-254 Jan 27, 2026
d1ba2d6
fix(organizational-chart): update can_create check for empty state re…
krishna-254 Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions hrms/public/js/hierarchy-chart.bundle.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import "./hierarchy_chart/hierarchy_chart_desktop.js";
import "./hierarchy_chart/hierarchy_chart_mobile.js";
import "./templates/node_card.html";
import "./templates/hierarchy_empty_state.html";
52 changes: 42 additions & 10 deletions hrms/public/js/hierarchy_chart/hierarchy_chart_desktop.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,22 +12,12 @@ hrms.HierarchyChart = class {
this.method = method;
this.doctype = doctype;

this.setup_page_style();
this.page.main.addClass("frappe-card");

this.nodes = {};
this.setup_node_class();
}

setup_page_style() {
this.page.main.css({
"min-height": "300px",
"max-height": "700px",
overflow: "auto",
position: "relative",
});
}

setup_node_class() {
let me = this;
this.Node = class {
Expand Down Expand Up @@ -228,6 +218,15 @@ hrms.HierarchyChart = class {
})
.then((r) => {
if (r.message.length) {
me.page.body.find("#hierarchy-empty-root").remove();

me.page.main.css({
"min-height": "300px",
"max-height": "700px",
overflow: "auto",
position: "relative",
});

let expand_node;
let node;

Expand Down Expand Up @@ -255,6 +254,39 @@ hrms.HierarchyChart = class {
if (!expanded_view) {
me.expand_node(expand_node);
}
} else {
me.page.body.find("#hierarchy-empty-root").remove();
const empty_html = frappe.render_template("hierarchy_empty_state", {
doctype: me.doctype,
company: me.company,
can_create: frappe.model.can_create(me.doctype),
device_type: "desktop",
});

$("#hierarchy-chart-wrapper").remove();
me.page.body.append(empty_html);

me.page.main.css({
"min-height": "100%",
"max-height": "100%",
});

(function () {
const root = document.getElementById("hierarchy-empty-root");
if (!root) return;
try {
const rect = root.getBoundingClientRect();
const windowHeight = window.innerHeight;
const height = Math.max(300, Math.floor(windowHeight - rect.top - 20));
root.style.height = height + "px";
root.style.overflow = "auto";
root.style.position = "relative";
} catch (e) {}
})();
me.page.body.find("#add-doc-btn").on("click", () => {
frappe.route_options = { company: me.company };
frappe.new_doc(me.doctype);
});
Comment on lines +257 to +289
Copy link
Copy Markdown
Member

@asmitahase asmitahase Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All these calculations aren't required here.
Just do a count call at the beginning in organization_chart.js and render the empty state html there if the employee count is 0.

Copy link
Copy Markdown
Member

@asmitahase asmitahase Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will need setting up the company filter outside the chart object.

}
});
}
Expand Down
49 changes: 43 additions & 6 deletions hrms/public/js/hierarchy_chart/hierarchy_chart_mobile.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,6 @@ hrms.HierarchyChartMobile = class {
this.method = method;
this.doctype = doctype;

this.page.main.css({
"min-height": "300px",
"max-height": "600px",
overflow: "auto",
position: "relative",
});
this.page.main.addClass("frappe-card");

this.nodes = {};
Expand Down Expand Up @@ -155,6 +149,15 @@ hrms.HierarchyChartMobile = class {
})
.then((r) => {
if (r.message.length) {
me.page.body.find("#hierarchy-empty-root").remove();

me.page.main.css({
"min-height": "300px",
"max-height": "600px",
overflow: "auto",
position: "relative",
});

let root_level = me.$hierarchy.find(".root-level");
root_level.empty();

Expand All @@ -171,6 +174,40 @@ hrms.HierarchyChartMobile = class {
is_root: true,
});
});
} else {
me.page.body.find("#hierarchy-empty-root").remove();
me.page.main.css({
"min-height": "100%",
"max-height": "100%",
overflow: "auto",
position: "relative",
});

const empty = frappe.render_template("hierarchy_empty_state", {
doctype: me.doctype,
company: me.company,
can_create: frappe.model.can_create(me.doctype),
device_type: "mobile",
});

me.page.main.append(empty);

(function () {
const root = document.getElementById("hierarchy-empty-root");
if (!root) return;
try {
const rect = root.getBoundingClientRect();
const windowHeight = window.innerHeight;
const height = Math.max(300, Math.floor(windowHeight - rect.top - 20));
root.style.height = height + "px";
root.style.overflow = "auto";
root.style.position = "relative";
} catch (e) {}
})();
me.page.body.find("#add-doc-btn").on("click", () => {
frappe.route_options = { company: me.company };
frappe.new_doc(me.doctype);
});
}
});
}
Expand Down
32 changes: 32 additions & 0 deletions hrms/public/js/templates/hierarchy_empty_state.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@

<div id="hierarchy-empty-root" class="text-muted flex flex-1 items-center justify-center align-center text-center">
<div class="">
<div class="empty-apps-state">
<svg class="icon icon-xl" style="stroke: var(--text-light);">
<use href="#icon-small-file"></use>
Copy link
Copy Markdown
Member

@asmitahase asmitahase Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use user-plus icon

Copy link
Copy Markdown
Member

@asmitahase asmitahase Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or pass a template variable to reuse this someplace else

Copy link
Copy Markdown
Member

@asmitahase asmitahase Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like Team Updates 😁

</svg>
<div class="mt-4 mb-2">
{{ __("You haven't created a {0} for {1} yet.", [__(doctype), __(company)]) }}
Copy link
Copy Markdown
Member

@asmitahase asmitahase Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep user messages short and human, something like "You haven't created any Employee for <company_name>"

</div>

{% if can_create %}
{% if device_type == "desktop" %}
<button
class="btn btn-default btn-sm btn-new-doc hidden-xs"
id="add-doc-btn"
>
{{ __("Create a new {0}", [__(doctype)]) }}
Copy link
Copy Markdown
Member

@asmitahase asmitahase Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep the labels short too, "Create New" or simply "Add Employee" should suffice

</button>
{% else %}
<button
class="btn btn-primary btn-new-doc visible-xs"
id="add-doc-btn"
>
{{ __("Create {0}", [__(doctype)]) }}
</button>
{% endif %}
{% endif %}

</div>
</div>
</div>