fix: use background job to bulk mark attendance for more than 10 records (backport #4239)#4245
Open
mergify[bot] wants to merge 3 commits intoversion-15-hotfixfrom
Open
fix: use background job to bulk mark attendance for more than 10 records (backport #4239)#4245mergify[bot] wants to merge 3 commits intoversion-15-hotfixfrom
mergify[bot] wants to merge 3 commits intoversion-15-hotfixfrom
Conversation
Contributor
Author
|
Cherry-pick of acf41ea has failed: Cherry-pick of cf1951c has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bulk mark attendance tool doesn't impose any limit on the number of dates a user can select to mark attendance. But it also tries to save all those records in a single request.
Screencast.From.2026-03-18.16-33-19.mp4
While this use is extreme, what is more common is user customisation causing saving of records to slow down and multiple users trying to mark attendance simultaneously which makes them run into deadlocks and timeouts.
Now less than 10 records are processed inside the http request, any more than, that are handed over to a background job that keeps committing in batches.
Screencast.From.2026-03-18.16-28-03.mp4
Summary by CodeRabbit
Release Notes
This is an automatic backport of pull request #4239 done by [Mergify](https://mergify.com).