-
Notifications
You must be signed in to change notification settings - Fork 277
fix: add setuptools to dependencies to resolve distutils error #491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
WalkthroughThe 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@pyproject.toml`:
- Around line 10-13: The pyproject.toml's project dependencies list currently
pins "setuptools" without a version constraint; change the "setuptools" entry in
the [project].dependencies array to "setuptools>=75.7.0" so runtime installs
include the version that supports the Python 3.13 distutils shim; update the
dependency string for "setuptools" (alongside existing "mistune>=3.0") to add
this minimum version constraint.
|
If I am not mistaken it was somewhere mentioned officially that Frappe 16 needs Python 3.14, meaning IMO it makes sense to use 3.14 here. Who can review this? As the App is currently broken because of this in Frappe 16 |
|
Thanks for pointing that out @MohammedNoureldin! I kept it at 3.13 for now because that’s the latest stable release and the distutils fix is working properly there. Since 3.14 is still in pre-alpha, making it a strict requirement might just block users who aren't on experimental versions yet. @NagariaHussain, what do you say? Should we keep it at 3.13 so everyone can use it, or do you want to change it to 3.14 to match Frappe 16? |
|
Maybe I am missing something, but for me the latest Python stable (not alpha) version is 3.14.3, if I am not mistaken I would use it. We still need someone to approve the PR and merge it back. |
|
FYI, I have just tested the new beta release: v3.0.0-beta.1, and I was able to create custom image with wiki app. |
Description
This PR resolves the
ModuleNotFoundError: No module named 'distutils'error reported in #490.Python 3.12+ has officially removed the
distutilsmodule. Since the Wiki app now targets modern Python versions (verified on Python 3.13), we need to explicitly includesetuptoolsin our dependencies.setuptoolsprovides the necessarydistutilsshim required for the build process to complete successfully.Key Changes
setuptoolsto thedependencieslist inpyproject.toml.Automated Tests
bench build --app wikion a local environment using Python 3.13.11. The build now completes successfully without crashing.Closes #490
Summary by CodeRabbit