This repository was archived by the owner on Oct 20, 2018. It is now read-only.
[DON'T-MERGE] Minor cleanups #163
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ES6 has default arguments (similar to those in Python), so the old syntax of `let arg = arg || "default"` should now be terminated in favour of a cleaner and more descriptive one. In addition, the HTTP timeout was set to 5000 yet the error would occur at 3000. I made the error happen later, as that can't break anything(?)
Author
|
In fact, we could make the README.md changes immediately and then I could split the code PR into a separate PR after some good testing? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't solve an issue. This hasn't been tested. This is a terrible pull request. I've decided to file it anyway, in case people have any quick suggestions for cleaning up the code.