refactor(.github): use rclone (refactor) for efficient (refactor) upload #355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raisedadead
approved these changes
Dec 11, 2025
Member
raisedadead
left a comment
raisedadead
left a comment
There was a problem hiding this comment.
Here is a fitting review 😈😤:
chore is NOT a valid conventional commit because this is a clear refactor.
Also this actions should not need to comment 7-8 lines about the rclone docs. Devs can RTFM.
Also thanks a lot.
ShaunSHamilton
changed the title
raisedadead
approved these changes
Dec 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even if I end up not using this repo for the Exam Environment stuff, I saw the state of the Action, and could not leave it.
We might want to consider running with
--dry-runinitially.