Skip to content

feat: add fruits search api#638

Merged
scissorsneedfoodtoo merged 5 commits intofreeCodeCamp:mainfrom
ihechikara:feat/add-live-search-workshop-api
Mar 27, 2025
Merged

feat: add fruits search api#638
scissorsneedfoodtoo merged 5 commits intofreeCodeCamp:mainfrom
ihechikara:feat/add-live-search-workshop-api

Conversation

@ihechikara
Copy link
Member

Checklist:

@ihechikara ihechikara marked this pull request as ready for review March 19, 2025 13:46
Copy link

@jdwilkin4 jdwilkin4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments 👍

@jdwilkin4
Copy link

Also, since the data is about fruits and no longer about tv shows, it doesn't seem like live search fits anymore.
So maybe something like Fruits lookup? Or some other name with fruits in the title.

Maybe others have better suggestions too 👍

@naomi-lgbt
Copy link
Member

it doesn't seem like live search fits anymore.
So maybe something like Fruits lookup?

I cast my vote for Fruit Salad.

@socket-security
Copy link

socket-security bot commented Mar 26, 2025

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/dotenv@16.4.7 environment, filesystem 0 75.8 kB motdotla
npm/express@4.21.2 environment, filesystem, network Transitive: eval +22 684 kB jonchurch

View full report↗︎

@jdwilkin4 jdwilkin4 changed the title feat: add live search api feat: add fruits search api Mar 26, 2025
Copy link
Contributor

@scissorsneedfoodtoo scissorsneedfoodtoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ihechikara, this all looks great.

I went through and left a few review comments. Most are minor, but the ones in server.js are necessary.

Please take a look when you can and ping me once you're finished. I can take another look and we can get this merged ASAP.

Copy link
Contributor

@scissorsneedfoodtoo scissorsneedfoodtoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took another look and everything LGTM 👍

@scissorsneedfoodtoo scissorsneedfoodtoo merged commit afa8419 into freeCodeCamp:main Mar 27, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants