Skip to content

fix: v6 bugs #1663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Sembauke merged 2 commits into from
Oct 14, 2025
Merged

fix: v6 bugs #1663

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
713c91a
fix: ios errors
Nirajn2311 Sep 3, 2025
a86870d
feat: update authentication service and pass widget to handle motivat…
Sembauke Sep 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions mobile-app/lib/ui/views/learn/challenge/challenge_viewmodel.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -712,7 +712,8 @@ class ChallengeViewModel extends BaseViewModel {
);
if (evalResult != null && evalResult.error != null) {
setUserConsoleMessages = [
...userConsoleMessages.sublist(0, userConsoleMessages.length - 1),
if (userConsoleMessages.isNotEmpty)
...userConsoleMessages.sublist(0, userConsoleMessages.length - 1),
'<p>${evalResult.error}</p>',
];
}
Expand Down Expand Up @@ -745,13 +746,16 @@ class ChallengeViewModel extends BaseViewModel {
'testStr': test.javaScript,
},
);
if (testRes?.value['pass'] == null) {
log('TEST FAILED: ${test.instruction} - ${test.javaScript} - ${testRes?.value['err']}');
if (testRes != null && testRes.value['pass'] == null) {
log('TEST FAILED: ${test.instruction} - ${test.javaScript} - ${testRes.value['err']}');
failedTest = failedTest ?? test;
failedTestErr = failedTestErr ?? testRes?.value['err'] as Map;
failedTestErr = failedTestErr ?? testRes.value['err'] as Map;
failedTestsConsole.add(
'<li>${replacePlaceholders(test.instruction, failedTestErr)}</li>',
);
} else if (testRes == null) {
log('TEST RESULT NULL: $testRes');
throw Exception('Test result is null ${testRes.toString()}');
}
}

Expand Down
11 changes: 11 additions & 0 deletions mobile-app/lib/ui/views/learn/widgets/pass/pass_widget_model.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,17 @@ import 'package:stacked/stacked.dart';
class PassWidgetModel extends BaseViewModel {
final AuthenticationService auth = locator<AuthenticationService>();

Future<MotivationalQuote>? quoteFuture;

set setQuoteFuture(Future<MotivationalQuote> value) {
quoteFuture = value;
notifyListeners();
}

void initQuoute() {
setQuoteFuture = retrieveNewQuote();
}

Future<int> numCompletedChallenges(ChallengeViewModel challengeModel) async {
FccUserModel? user = await auth.userModel;
if (user != null) {
Expand Down
3 changes: 2 additions & 1 deletion mobile-app/lib/ui/views/learn/widgets/pass/pass_widget_view.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ class PassWidgetView extends StatelessWidget {
Widget build(BuildContext context) {
return ViewModelBuilder<PassWidgetModel>.reactive(
viewModelBuilder: () => PassWidgetModel(),
onViewModelReady: (model) => model.initQuoute(),
builder: (context, model, child) => SafeArea(
child: Column(
children: [
Expand All @@ -48,7 +49,7 @@ class PassWidgetView extends StatelessWidget {
crossAxisAlignment: CrossAxisAlignment.start,
children: [
FutureBuilder(
future: model.retrieveNewQuote(),
future: model.quoteFuture,
builder: (context, snapshot) {
if (snapshot.hasData) {
MotivationalQuote quote =
Expand Down
Loading