ipfw: do not use errno value for error reporting

lytboris · bu7cher · commit dfd822b1f084 · 2025-10-14T11:02:20.000+03:00
table_do_modify_record() already uses errno value on error. Also this fixes problem when `ipfw table add` returns ENOTTY that is unrelated to operation. Tested by: dhw Fixes: 09025a7 MFC after: 3 days Differential Revision: https://reviews.freebsd.org/D53050
diff --git a/sbin/ipfw/tables.c b/sbin/ipfw/tables.c
@@ -1037,9 +1037,6 @@ table_modify_record(ipfw_obj_header *oh, int ac, char *av[], int add,
 		}
 	}
 
-	/* Get real OS error */
-	error = errno;
-
 	/* Report results back */
 	ptent = tent_buf;
 	for (i = 0; i < count; ptent++, i++) {

Original file line number	Diff line number	Diff line change
`@@ -1037,9 +1037,6 @@ table_modify_record(ipfw_obj_header oh, int ac, char av[], int add,`
`1037`	`1037`	`}`
`1038`	`1038`	`}`
`1039`	`1039`
`1040`		`- /* Get real OS error */`
`1041`		`- error = errno;`
`1042`		`-`
`1043`	`1040`	`/* Report results back */`
`1044`	`1041`	`ptent = tent_buf;`
`1045`	`1042`	`for (i = 0; i < count; ptent++, i++) {`