Skip to content

Conversation

@deeplow
Copy link
Contributor

@deeplow deeplow commented Oct 23, 2025

This misisng shebang lead to an execve error in Qubes 4.3

Fixes #2770

Test plan

In 4.2:

  • try-client-pr 1461
  • ensure client logs in (otherwise it would fail the login)

In 4.3: WIP

Checklist

This change accounts for:

  • testing changes on Qubes as needed (especially changes related to cryptography, export, disposable VM use, or complex UI changes)
  • any needed updates to the AppArmor profile for files beyond the application code
  • any needed self-contained database migrations (including testing against a clean test database from main)

This misisng shebang lead to an execve error in Qubes 4.3

Fixes #2770
@deeplow
Copy link
Contributor Author

deeplow commented Oct 23, 2025

Marking as ready for review, but under the understanding that to verify in 4.3 without doing a 4.3 install is not yet ready.

@deeplow deeplow marked this pull request as ready for review October 23, 2025 16:30
@deeplow deeplow requested a review from a team as a code owner October 23, 2025 16:30
@legoktm
Copy link
Member

legoktm commented Oct 23, 2025

Does securedrop.Log need the same fix?

@legoktm legoktm moved this to Ready For Review in SecureDrop Oct 23, 2025
@deeplow
Copy link
Contributor Author

deeplow commented Oct 23, 2025

Good point.

@legoktm legoktm self-assigned this Oct 24, 2025
Copy link
Member

@legoktm legoktm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified that I could log in and that logs were flowing.

@legoktm legoktm added this pull request to the merge queue Oct 24, 2025
Merged via the queue into main with commit a9682c1 Oct 24, 2025
60 of 61 checks passed
@legoktm legoktm deleted the 1461-proxy-rpc-shebang branch October 24, 2025 16:00
@github-project-automation github-project-automation bot moved this from Ready For Review to Done in SecureDrop Oct 24, 2025
@nathandyer nathandyer removed this from SecureDrop Nov 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

securedrop.Proxy call leads to execve: Exec format error (Qubes 4.3)

2 participants