Debug pipeline test failure on main branch #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add 'form' to SEMANTIC_TAGS in elementCollector.ts Form elements weren't being traversed in snapshot tree walker, causing form inputs to be missing from uidMap - Update selectTab() and createNewPage() to set cachedSelectedIdx getSelectedTabIdx() was returning stale value after tab switch - Fix network test for file:// protocol file:// URLs don't produce BiDi network events (local files don't go through network layer). Test now correctly verifies monitoring is active without expecting page load network event
freema
deleted the
claude/debug-pipeline-test-failure-01WRSjpeZ9SSv3r3SqNGAYZM
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add 'form' to SEMANTIC_TAGS in elementCollector.ts Form elements weren't being traversed in snapshot tree walker, causing form inputs to be missing from uidMap
Update selectTab() and createNewPage() to set cachedSelectedIdx getSelectedTabIdx() was returning stale value after tab switch
Fix network test for file:// protocol file:// URLs don't produce BiDi network events (local files don't go through network layer). Test now correctly verifies monitoring is active without expecting page load network event