Add setup intents #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…upintent for stripe.
Contributor
Author
|
Should I actually call it |
| break; | ||
| } | ||
| case STPPaymentHandlerActionStatusSucceeded: { | ||
| completion(setupIntent.paymentMethodID, nil); |
Member
There was a problem hiding this comment.
Nice, so we have validated that we can get the method ID out of this method
js/index.js
Outdated
| @@ -1,2 +1,3 @@ | |||
| export { default as PaymentRequest } from './PaymentRequest'; | |||
| export { PKPaymentButton } from './PKPaymentButton'; | |||
| export { Intents } from './Intents'; | |||
Member
There was a problem hiding this comment.
Nice, I like it. Maybe better to do an export default in Intents.js and then export { default as Intents } here. Saves you embedding everything inside a single object
| cardParams: (NSDictionary *)cardParams | ||
| callback: (RCTResponseSenderBlock)callback) | ||
| { | ||
| NSString *merchantId = methodData[@"merchantIdentifier"]; |
Member
There was a problem hiding this comment.
merchantId is pk_test_... right?
ios/GatewayManager.m
Outdated
| card.expYear = [RCTConvert NSNumber:cardParams[@"expYear"]]; | ||
| card.expMonth = [RCTConvert NSNumber:cardParams[@"expMonth"]]; | ||
| card.cvc = [RCTConvert NSString:cardParams[@"cvc"]]; | ||
| STPPaymentMethodParams *paymentMethodParams = [STPPaymentMethodParams paramsWithCard:card billingDetails:nil metadata:nil]; |
Member
There was a problem hiding this comment.
Maybe here, paramsWithCard could potentially be paramsWithToken
Contributor
Author
There was a problem hiding this comment.
If it can I don't know https://stripe.dev/stripe-ios/docs/Classes/STPPaymentMethodParams.html
…urrently. better to get on android first
…ling with onActivityResult stuff
…ese, just gonna see if it works)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the stripe function confirmSetupIntent. Use in project as