Skip to content

fix: popover and listboxitem styling #489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shiba-codes merged 4 commits into from
Nov 11, 2024
Merged

fix: popover and listboxitem styling #489

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2fd2400
feat(popover): move even-width-with-trigger styling to popover
Nov 11, 2024
5959a01
fix(list-box): fix styling when listbox item is a link
Nov 11, 2024
7edd3b7
fix(icon-button): fix duplicate selector
Nov 11, 2024
d096700
fix(popover): fix syntax
Nov 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/components/experimental/ComboBox/ComboBox.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,7 @@ const defaultAriaStrings = {
};

const StyledPopover = styled(Popover)`
box-sizing: border-box;
overflow: auto;
width: var(--trigger-width);
`;

interface ComboBoxFieldProps extends Pick<FieldProps, 'label' | 'description' | 'errorMessage' | 'leadingIcon'> {
Expand Down
12 changes: 2 additions & 10 deletions src/components/experimental/IconButton/IconButton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ const StandardIconContainer = styled(Button)<Omit<IconButtonProps, 'Icon'>>`
&[data-disabled],
&[data-pending] {
cursor: not-allowed;
opacity: 0.38;
}

/* we create a before pseudo element to mess with the opacity (see the hovered state) */
Expand All @@ -50,11 +51,6 @@ const StandardIconContainer = styled(Button)<Omit<IconButtonProps, 'Icon'>>`
&:not([data-disabled]) {
color: ${props => (props.isActive ? getSemanticValue('interactive') : getSemanticValue('on-surface'))};
}

&[data-disabled],
&[data-pending] {
opacity: 0.38;
}
`;

const TonalIconContainer = styled(Button)<Omit<IconButtonProps, 'Icon'>>`
Expand All @@ -69,6 +65,7 @@ const TonalIconContainer = styled(Button)<Omit<IconButtonProps, 'Icon'>>`
&[data-disabled],
&[data-pending] {
cursor: not-allowed;
opacity: 0.38;
}

/* we create a before pseudo element to mess with the opacity (see the hovered state) */
Expand Down Expand Up @@ -104,11 +101,6 @@ const TonalIconContainer = styled(Button)<Omit<IconButtonProps, 'Icon'>>`
color: ${props =>
props.isActive ? getSemanticValue('on-interactive-container') : getSemanticValue('on-surface')};
}

&[data-disabled],
&[data-pending] {
opacity: 0.38;
}
`;

export const IconButton = ({
Expand Down
1 change: 1 addition & 0 deletions src/components/experimental/ListBox/ListBox.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import { getSemanticValue } from '../../../essentials/experimental';

const StyledListBoxItem = styled(BaseListBoxItem)`
position: relative;
display: block;
padding: ${get('space.3')} ${get('space.4')};
border-radius: ${get('radii.4')};
color: ${getSemanticValue('on-surface')};
Expand Down
6 changes: 6 additions & 0 deletions src/components/experimental/Popover/Popover.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,12 @@ const StyledPopover = styled(BasePopover)`
box-shadow: 0 2px 4px -1px hsla(0, 0%, 0%, 0.2), 0 1px 10px 0 hsla(0, 0%, 0%, 0.12),
0 4px 5px 0 hsla(0, 0%, 0%, 0.14);
border-radius: ${get('radii.4')};

&[data-trigger='Select'],
&[data-trigger='ComboBox'] {
box-sizing: border-box;
width: var(--trigger-width);
}
`;

const FocusTrap = styled(Dialog)`
Expand Down
2 changes: 0 additions & 2 deletions src/components/experimental/Select/Select.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,7 @@ import { VisuallyHidden } from '../../VisuallyHidden/VisuallyHidden';
import { fieldStyles, fieldTextStyles } from '../Field/Field';

const StyledPopover = styled(Popover)`
box-sizing: border-box;
overflow: auto;
width: var(--trigger-width);
`;

const FakeButton = styled(FakeInput)`
Expand Down