fix: remove prop type overriding and add event type in snackbar #500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlanFnz
requested review from
shiba-codes
and removed request for
jonotrujillo
shiba-codes
approved these changes
Dec 2, 2024
AlanFnz
changed the title
github-actions bot
pushed a commit
that referenced
this pull request
Dec 2, 2024
### [2.19.2](v2.19.1...v2.19.2) (2024-12-02) ### Bug Fixes * remove prop type overriding and add event type in snackbar ([#500](#500)) ([c4d4db8](c4d4db8))
Contributor
|
🎉 This PR is included in version 2.19.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR removes the overriding of the
onPressprop when extending the interface for theIconButtoncomponent.It also adds the correct event typing in
SnackbarWhy
This override we are removing causes us to lose the event typing inherited from
AriaButtonProps