Skip to content

fix: avoid isLoading prop on button element #530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonotrujillo merged 1 commit into from
May 8, 2025
Merged

fix: avoid isLoading prop on button element #530

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/components/experimental/Button/Button.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,15 +116,15 @@ const ButtonStyled = styled(BaseButton)<{ $emphasis: Emphasis }>`
${emphasisStyles};
`;

const ChildrenContainer = styled.span<{ isLoading: boolean }>`
const ChildrenContainer = styled.span<{ $isLoading: boolean }>`
display: inline-flex;
align-items: center;
justify-content: center;
gap: ${get('space.2')};
padding: ${get('space.4')} ${get('space.6')};

opacity: ${({ isLoading }) => (isLoading ? 0 : 1)};
visibility: ${({ isLoading }) => (isLoading ? 'hidden' : 'visible')};
opacity: ${({ $isLoading }) => ($isLoading ? 0 : 1)};
visibility: ${({ $isLoading }) => ($isLoading ? 'hidden' : 'visible')};
transition: opacity ease 200ms;
`;

Expand All @@ -148,7 +148,7 @@ const spinnerColor: Record<Emphasis, string> = {
function Button({ children, emphasis = 'primary', isLoading = false, ...restProps }: ButtonProps): ReactElement {
const renderContent = (props: ButtonRenderProps & { defaultChildren: ReactNode }) => (
<>
<ChildrenContainer isLoading={isLoading}>
<ChildrenContainer $isLoading={isLoading}>
{typeof children === 'function' ? children(props) : children}
</ChildrenContainer>
{isLoading && (
Expand Down