Introduce support for multiple logging providers.#135
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #135 +/- ##
==========================================
+ Coverage 98.72% 99.35% +0.63%
==========================================
Files 14 14
Lines 1407 1391 -16
==========================================
- Hits 1389 1382 -7
+ Misses 14 7 -7
+ Partials 4 2 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This reverts commit 445fcb8.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Up to this point, we only supported using
zapas the logging package. These changes add support for the following packages:loglog/sloglogrusAdditionally, the
unit.WithLoggeroption allows for supporting arbitrary custom loggers that support theunit.Loggerinterface.Rationale
Supporting only
zapimposes this package on clients of this package if they desire to having logging enabled. There are many logging solutions available, so only supporting a single package limiting.Suggested Version
v4.0.0-beta.7Example Usage