Open
Conversation
… dtype np.int_ (was string 'int64') causing buffer dtype mismatch
Member
|
Sorry @DylanHsu for letting this hang. There have been some changes to both of those files. If you resolve the conflicts I can merge the PR. I think |
Contributor
|
Things build and import okay in #66 with no additional flags. If things don't actually work, would be good to add more comprehensive tests that would show the problems |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Surfa was almost working out of the box on Windows 11 with Python 12 and the Visual Studio 2022 compiler (MSVC 22).
I modified setup.py to use MSVC flags. I also fixed one dtype issue in interp.pyx
There may be more issues, but this was enough to let me use mri_synthstrip.