Revert changes to ftdm_set_string, closes #7#8
Open
xadhoom wants to merge 1 commit intofreeswitch:masterfrom
Open
Revert changes to ftdm_set_string, closes #7#8xadhoom wants to merge 1 commit intofreeswitch:masterfrom
xadhoom wants to merge 1 commit intofreeswitch:masterfrom
Conversation
By doing a memcpy and using sizeof of the smaller argument, if the source argument is a pointer, on 64bits arches the sizeof(y) will be 8, which results in truncating the copied string to 8 chars.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By doing a memcpy and using sizeof of the smaller argument, if the source argument is a pointer, on 64bits arches the sizeof(y) will be 8, which results in truncating the copied string to 8 chars.
This wil address #7