-
-
Notifications
You must be signed in to change notification settings - Fork 37
feat: intial prom endpoint #1031
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Thanks for creating a pull request! A maintainer will review your changes shortly. Please don't be discouraged if it takes a while. |
8331da0 to
fc01afc
Compare
|
Was able to test it on my end @T0biii @DasSkelett |
|
maybe @Operating3336 can test this pr as well? |
|
@Operating3336 you can test this out by using the docker pull ghcr.io/freifunkmuc/wg-access-server:prometheus tag. Feedback would be much appreciated :) |
|
@copilot I've got the following task: Switch default metadata exposure for Prometheus endpoint. Currently, the VPN server Prometheus endpoint uses DisableMetadata by default. Exposing user stats by default might not be fully privacy-compliant. Replace DisableMetadata with EnableMetadata in the implementation. Change the logic to honor that. Update the docs as well. |
|
@GoliathLabs I've opened a new pull request, #1051, to work on those changes. Once the pull request is ready, I'll request review from you. |
…efaults (#1051) * Initial plan * Switch from DisableMetadata to EnableMetadata with default false Co-authored-by: GoliathLabs <8057646+GoliathLabs@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: GoliathLabs <8057646+GoliathLabs@users.noreply.github.com>
Here's a possible fix for #918.
Hasn't been tested yet.
Closes #918