Skip to content

Fix for creating S3 bucket (#26). #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jjacobson93 wants to merge 1 commit into
base: master
Choose a base branch
from
+7 −5
Open

Fix for creating S3 bucket (#26). #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions scripts/core/helper.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,11 +193,13 @@ mountUriS3(){
}

createS3Bucket(){
local createBucket=$1;
local bucketS3Uri=$2;

# Check if create is required
if [ "$AWS_S3_BUCKET_CREATE" = "true" ]; then
local bucketS3Uri="s3://$AWS_S3_BUCKET_NAME"
if [ "$createBucket" = "true" ]; then
# Test if bucket doesn't exists
if aws s3 ls "s3://$AWS_S3_BUCKET_NAME" 2>&1 | grep -q 'NoSuchBucket'; then
if aws s3 ls "$bucketS3Uri" 2>&1 | grep -q 'NoSuchBucket'; then
# Create bucket
local s3BucketCreationResult=$(aws s3 mb "$bucketS3Uri")
echo "$s3BucketCreationResult"
Expand Down
2 changes: 1 addition & 1 deletion scripts/provider/aws/sync/upload.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ uploadSync(){
#Call to mount uri S3.
s3Uri=$(mountUriS3 "/" $AWS_S3_BUCKET_NAME $AWS_S3_PATH)

local createS3BucketResult=$(createS3Bucket)
local createS3BucketResult=$(createS3Bucket $AWS_S3_BUCKET_CREATE $AWS_S3_BUCKET_NAME)
echo "$createS3BucketResult"

echo "Starting Upload Sync from: $DATA_PATH/ to $s3Uri/"
Expand Down
2 changes: 1 addition & 1 deletion scripts/provider/aws/tarball/upload.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ uploadTarball(){
#Call to mount uri S3.
s3Uri=$(mountUriS3 $1 $AWS_S3_BUCKET_NAME $AWS_S3_PATH)

local createS3BucketResult=$(createS3Bucket)
local createS3BucketResult=$(createS3Bucket $AWS_S3_BUCKET_CREATE $AWS_S3_BUCKET_NAME)
echo "$createS3BucketResult"

echo "Starting Upload Tarball from: /tmp/$1 to $s3Uri"
Expand Down