fix: Correct placeholders in Czech translation#1190
Open
Petroni2022 wants to merge 1 commit intofrenck:mainfrom
Open
fix: Correct placeholders in Czech translation#1190Petroni2022 wants to merge 1 commit intofrenck:mainfrom
Petroni2022 wants to merge 1 commit intofrenck:mainfrom
Conversation
Contributor
📝 WalkthroughWalkthroughThis PR adds extensive gitignore patterns for Visual Studio, .NET, and multiple development ecosystems, and corrects Czech translation placeholders in the Spook integration from Czech-style to English-style formatting. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.gitignore:
- Around line 116-574: Revert the large unrelated addition in .gitignore (the
block that added Visual Studio/PlatformIO patterns such as the VisualStudio
template entries and the "Naimportováno z Platfomio" section) by removing lines
that introduce patterns like __pycache__/, node_modules/, interface/src/i18n/,
src/ESP32React/WWWData.h, sdkconfig.*, CMakeLists.txt, [Ll]og/, artifacts/, and
other .NET/MSBuild/NuGet/PlatformIO-specific rules (the entire insertion between
the Visual Studio template start and the PlatformIO footer). Remove any
duplicate patterns introduced (e.g., __pycache__/, node_modules/, build/, dist/,
venv/, .DS_Store) so the file only contains patterns relevant to this Python
Home Assistant integration; if any of the removed patterns are genuinely needed,
add a minimal, focused subset in a separate PR referencing those specific
patterns.
Comment on lines
+116
to
+574
|
|
||
|
|
||
| ## Ignore Visual Studio temporary files, build results, and | ||
| ## files generated by popular Visual Studio add-ons. | ||
| ## | ||
| ## Get latest from https://github.com/github/gitignore/blob/master/VisualStudio.gitignore | ||
|
|
||
| # User-specific files | ||
| *.rsuser | ||
| *.suo | ||
| *.user | ||
| *.userosscache | ||
| *.sln.docstates | ||
|
|
||
| # User-specific files (MonoDevelop/Xamarin Studio) | ||
| *.userprefs | ||
|
|
||
| # Mono auto generated files | ||
| mono_crash.* | ||
|
|
||
| # Build results | ||
| [Dd]ebug/ | ||
| [Dd]ebugPublic/ | ||
| [Rr]elease/ | ||
| [Rr]eleases/ | ||
| x64/ | ||
| x86/ | ||
| [Ww][Ii][Nn]32/ | ||
| [Aa][Rr][Mm]/ | ||
| [Aa][Rr][Mm]64/ | ||
| bld/ | ||
| [Bb]in/ | ||
| [Oo]bj/ | ||
| [Oo]ut/ | ||
| [Ll]og/ | ||
| [Ll]ogs/ | ||
|
|
||
| # Visual Studio 2015/2017 cache/options directory | ||
| .vs/ | ||
| # Uncomment if you have tasks that create the project's static files in wwwroot | ||
| #wwwroot/ | ||
|
|
||
| # Visual Studio 2017 auto generated files | ||
| Generated\ Files/ | ||
|
|
||
| # MSTest test Results | ||
| [Tt]est[Rr]esult*/ | ||
| [Bb]uild[Ll]og.* | ||
|
|
||
| # NUnit | ||
| *.VisualState.xml | ||
| TestResult.xml | ||
| nunit-*.xml | ||
|
|
||
| # Build Results of an ATL Project | ||
| [Dd]ebugPS/ | ||
| [Rr]eleasePS/ | ||
| dlldata.c | ||
|
|
||
| # Benchmark Results | ||
| BenchmarkDotNet.Artifacts/ | ||
|
|
||
| # .NET Core | ||
| project.lock.json | ||
| project.fragment.lock.json | ||
| artifacts/ | ||
|
|
||
| # ASP.NET Scaffolding | ||
| ScaffoldingReadMe.txt | ||
|
|
||
| # StyleCop | ||
| StyleCopReport.xml | ||
|
|
||
| # Files built by Visual Studio | ||
| *_i.c | ||
| *_p.c | ||
| *_h.h | ||
| *.ilk | ||
| *.meta | ||
| *.obj | ||
| *.iobj | ||
| *.pch | ||
| *.pdb | ||
| *.ipdb | ||
| *.pgc | ||
| *.pgd | ||
| *.rsp | ||
| *.sbr | ||
| *.tlb | ||
| *.tli | ||
| *.tlh | ||
| *.tmp | ||
| *.tmp_proj | ||
| *_wpftmp.csproj | ||
| *.log | ||
| *.vspscc | ||
| *.vssscc | ||
| .builds | ||
| *.pidb | ||
| *.svclog | ||
| *.scc | ||
|
|
||
| # Chutzpah Test files | ||
| _Chutzpah* | ||
|
|
||
| # Visual C++ cache files | ||
| ipch/ | ||
| *.aps | ||
| *.ncb | ||
| *.opendb | ||
| *.opensdf | ||
| *.sdf | ||
| *.cachefile | ||
| *.VC.db | ||
| *.VC.VC.opendb | ||
|
|
||
| # Visual Studio profiler | ||
| *.psess | ||
| *.vsp | ||
| *.vspx | ||
| *.sap | ||
|
|
||
| # Visual Studio Trace Files | ||
| *.e2e | ||
|
|
||
| # TFS 2012 Local Workspace | ||
| $tf/ | ||
|
|
||
| # Guidance Automation Toolkit | ||
| *.gpState | ||
|
|
||
| # ReSharper is a .NET coding add-in | ||
| _ReSharper*/ | ||
| *.[Rr]e[Ss]harper | ||
| *.DotSettings.user | ||
|
|
||
| # TeamCity is a build add-in | ||
| _TeamCity* | ||
|
|
||
| # DotCover is a Code Coverage Tool | ||
| *.dotCover | ||
|
|
||
| # AxoCover is a Code Coverage Tool | ||
| .axoCover/* | ||
| !.axoCover/settings.json | ||
|
|
||
| # Coverlet is a free, cross platform Code Coverage Tool | ||
| coverage*.json | ||
| coverage*.xml | ||
| coverage*.info | ||
|
|
||
| # Visual Studio code coverage results | ||
| *.coverage | ||
| *.coveragexml | ||
|
|
||
| # NCrunch | ||
| _NCrunch_* | ||
| .*crunch*.local.xml | ||
| nCrunchTemp_* | ||
|
|
||
| # MightyMoose | ||
| *.mm.* | ||
| AutoTest.Net/ | ||
|
|
||
| # Web workbench (sass) | ||
| .sass-cache/ | ||
|
|
||
| # Installshield output folder | ||
| [Ee]xpress/ | ||
|
|
||
| # DocProject is a documentation generator add-in | ||
| DocProject/buildhelp/ | ||
| DocProject/Help/*.HxT | ||
| DocProject/Help/*.HxC | ||
| DocProject/Help/*.hhc | ||
| DocProject/Help/*.hhk | ||
| DocProject/Help/*.hhp | ||
| DocProject/Help/Html2 | ||
| DocProject/Help/html | ||
|
|
||
| # Click-Once directory | ||
| publish/ | ||
|
|
||
| # Publish Web Output | ||
| *.[Pp]ublish.xml | ||
| *.azurePubxml | ||
| # Note: Comment the next line if you want to checkin your web deploy settings, | ||
| # but database connection strings (with potential passwords) will be unencrypted | ||
| *.pubxml | ||
| *.publishproj | ||
|
|
||
| # Microsoft Azure Web App publish settings. Comment the next line if you want to | ||
| # checkin your Azure Web App publish settings, but sensitive information contained | ||
| # in these scripts will be unencrypted | ||
| PublishScripts/ | ||
|
|
||
| # NuGet Packages | ||
| *.nupkg | ||
| # NuGet Symbol Packages | ||
| *.snupkg | ||
| # The packages folder can be ignored because of Package Restore | ||
| **/[Pp]ackages/* | ||
| # except build/, which is used as an MSBuild target. | ||
| !**/[Pp]ackages/build/ | ||
| # Uncomment if necessary however generally it will be regenerated when needed | ||
| #!**/[Pp]ackages/repositories.config | ||
| # NuGet v3's project.json files produces more ignorable files | ||
| *.nuget.props | ||
| *.nuget.targets | ||
|
|
||
| # Microsoft Azure Build Output | ||
| csx/ | ||
| *.build.csdef | ||
|
|
||
| # Microsoft Azure Emulator | ||
| ecf/ | ||
| rcf/ | ||
|
|
||
| # Windows Store app package directories and files | ||
| AppPackages/ | ||
| BundleArtifacts/ | ||
| Package.StoreAssociation.xml | ||
| _pkginfo.txt | ||
| *.appx | ||
| *.appxbundle | ||
| *.appxupload | ||
|
|
||
| # Visual Studio cache files | ||
| # files ending in .cache can be ignored | ||
| *.[Cc]ache | ||
| # but keep track of directories ending in .cache | ||
| !?*.[Cc]ache/ | ||
|
|
||
| # Others | ||
| ClientBin/ | ||
| ~$* | ||
| *~ | ||
| *.dbmdl | ||
| *.dbproj.schemaview | ||
| *.jfm | ||
| *.pfx | ||
| *.publishsettings | ||
| orleans.codegen.cs | ||
|
|
||
| # Including strong name files can present a security risk | ||
| # (https://github.com/github/gitignore/pull/2483#issue-259490424) | ||
| #*.snk | ||
|
|
||
| # Since there are multiple workflows, uncomment next line to ignore bower_components | ||
| # (https://github.com/github/gitignore/pull/1529#issuecomment-104372622) | ||
| #bower_components/ | ||
|
|
||
| # RIA/Silverlight projects | ||
| Generated_Code/ | ||
|
|
||
| # Backup & report files from converting an old project file | ||
| # to a newer Visual Studio version. Backup files are not needed, | ||
| # because we have git ;-) | ||
| _UpgradeReport_Files/ | ||
| Backup*/ | ||
| UpgradeLog*.XML | ||
| UpgradeLog*.htm | ||
| ServiceFabricBackup/ | ||
| *.rptproj.bak | ||
|
|
||
| # SQL Server files | ||
| *.mdf | ||
| *.ldf | ||
| *.ndf | ||
|
|
||
| # Business Intelligence projects | ||
| *.rdl.data | ||
| *.bim.layout | ||
| *.bim_*.settings | ||
| *.rptproj.rsuser | ||
| *- [Bb]ackup.rdl | ||
| *- [Bb]ackup ([0-9]).rdl | ||
| *- [Bb]ackup ([0-9][0-9]).rdl | ||
|
|
||
| # Microsoft Fakes | ||
| FakesAssemblies/ | ||
|
|
||
| # GhostDoc plugin setting file | ||
| *.GhostDoc.xml | ||
|
|
||
| # Node.js Tools for Visual Studio | ||
| .ntvs_analysis.dat | ||
| node_modules/ | ||
|
|
||
| # Visual Studio 6 build log | ||
| *.plg | ||
|
|
||
| # Visual Studio 6 workspace options file | ||
| *.opt | ||
|
|
||
| # Visual Studio 6 auto-generated workspace file (contains which files were open etc.) | ||
| *.vbw | ||
|
|
||
| # Visual Studio LightSwitch build output | ||
| **/*.HTMLClient/GeneratedArtifacts | ||
| **/*.DesktopClient/GeneratedArtifacts | ||
| **/*.DesktopClient/ModelManifest.xml | ||
| **/*.Server/GeneratedArtifacts | ||
| **/*.Server/ModelManifest.xml | ||
| _Pvt_Extensions | ||
|
|
||
| # Paket dependency manager | ||
| .paket/paket.exe | ||
| paket-files/ | ||
|
|
||
| # FAKE - F# Make | ||
| .fake/ | ||
|
|
||
| # CodeRush personal settings | ||
| .cr/personal | ||
|
|
||
| # Python Tools for Visual Studio (PTVS) | ||
| __pycache__/ | ||
| *.pyc | ||
|
|
||
| # Cake - Uncomment if you are using it | ||
| # tools/** | ||
| # !tools/packages.config | ||
|
|
||
| # Tabs Studio | ||
| *.tss | ||
|
|
||
| # Telerik's JustMock configuration file | ||
| *.jmconfig | ||
|
|
||
| # BizTalk build output | ||
| *.btp.cs | ||
| *.btm.cs | ||
| *.odx.cs | ||
| *.xsd.cs | ||
|
|
||
| # OpenCover UI analysis results | ||
| OpenCover/ | ||
|
|
||
| # Azure Stream Analytics local run output | ||
| ASALocalRun/ | ||
|
|
||
| # MSBuild Binary and Structured Log | ||
| *.binlog | ||
|
|
||
| # NVidia Nsight GPU debugger configuration file | ||
| *.nvuser | ||
|
|
||
| # MFractors (Xamarin productivity tool) working folder | ||
| .mfractor/ | ||
|
|
||
| # Local History for Visual Studio | ||
| .localhistory/ | ||
|
|
||
| # BeatPulse healthcheck temp database | ||
| healthchecksdb | ||
|
|
||
| # Backup folder for Package Reference Convert tool in Visual Studio 2017 | ||
| MigrationBackup/ | ||
|
|
||
| # Ionide (cross platform F# VS Code tools) working folder | ||
| .ionide/ | ||
|
|
||
| # Fody - auto-generated XML schema | ||
| FodyWeavers.xsd | ||
|
|
||
|
|
||
| #Ignore files built by Visual Studio/Visual Micro | ||
| [Dd]ebug*/ | ||
| [Rr]elease*/ | ||
| /__vm/ | ||
| __vm/ | ||
| *.vcxproj.* | ||
| *.vcxproj | ||
| /__vm/Upload.vmps.xml | ||
| /__vm/Compile.vmps.xml | ||
| .vcxproj.filters | ||
| .vcxproj.user | ||
|
|
||
|
|
||
|
|
||
| # Naimportováno z Platfomio ########################################################## | ||
| # vscode | ||
| .vscode/c_cpp_properties.json | ||
| .vscode/extensions.json | ||
| .vscode/launch.json | ||
|
|
||
| # c++ compiling | ||
| .clang_complete | ||
| .gcc-flags.json | ||
| cppcheck.out.xml | ||
|
|
||
| # platformio | ||
| .pio | ||
| pio_local.ini | ||
|
|
||
| # OS specific | ||
| .DS_Store | ||
| *Thumbs.db | ||
|
|
||
| # web specific | ||
| build/ | ||
| dist/ | ||
| /data/www | ||
| /interface/build | ||
| node_modules | ||
| /interface/.eslintcache | ||
| stats.html | ||
| *.sln | ||
| *.sw? | ||
| .pnp.* | ||
| analyse.html | ||
| interface/vite.config.ts.timestamp* | ||
| *.local | ||
| src/ESP32React/WWWData.h | ||
|
|
||
| # i18n generated files | ||
| interface/src/i18n/i18n-react.tsx | ||
| interface/src/i18n/i18n-types.ts | ||
| interface/src/i18n/i18n-util.ts | ||
| interface/src/i18n/i18n-util.sync.ts | ||
| interface/src/i18n/i18n-util.async.ts | ||
|
|
||
| # scripts | ||
| test.sh | ||
| scripts/run.sh | ||
| scripts/__pycache__ | ||
| scripts/stackdmp.txt | ||
|
|
||
| # sonar | ||
| .scannerwork/ | ||
| sonar/ | ||
| bw-output/ | ||
|
|
||
| # standalone executable for testing | ||
| emsesp | ||
| interface/tsconfig.tsbuildinfo | ||
|
|
||
| # python virtual environment | ||
| venv/ | ||
|
|
||
| # cspell | ||
| words-found-verbose.txt | ||
|
|
||
| # sonarlint | ||
| compile_commands.json | ||
|
|
||
| # pioarduino + hybrid | ||
| managed_components | ||
| dependencies.lock | ||
| CMakeLists.txt | ||
| .dummy/* | ||
| logs/* | ||
| sdkconfig.* | ||
| sdkconfig_tasmota_esp32 | ||
| pnpm-lock.yaml | ||
| .cache/ | ||
| interface/.tsbuildinfo | ||
| test/test_api/package-lock.json |
Contributor
There was a problem hiding this comment.
Unrelated additions — should be removed or separated from this translation fix PR.
The entire new block (lines 116–574) is unrelated to the stated PR goal of fixing Czech translation placeholders and to this project (a Python-only Home Assistant custom integration):
- Lines 118–481 are a standard Visual Studio / .NET / MSBuild / NuGet / Azure / Xamarin gitignore template. None of these tools or artifacts apply to a pure Python HA integration.
- Lines 483–574 are explicitly copied from a PlatformIO / ESP32 project (the Czech comment at line 497 reads "Naimportováno z Platformio" — "Imported from PlatformIO"). Patterns like
src/ESP32React/WWWData.h,sdkconfig.*,interface/src/i18n/, andCMakeLists.txthave no relevance here.
Additionally, the block introduces several duplicate rules already present in the file:
| Pattern | Existing line | Duplicate line |
|---|---|---|
__pycache__/ |
2 | 433 |
node_modules/ |
103 | 403 |
build/ |
33 | 517 |
dist/ |
35 | 518 |
venv/ |
72 | 555 |
.DS_Store |
7 | 513 |
Some new patterns are also overly broad for this repo:
[Ll]og/(line 150) and*.log(line 210) could silently hide Home Assistant log output.artifacts/(line 181) is used by GitHub Actions to store CI artifacts.
Please revert lines 116–574 and, if any of these patterns are genuinely needed, add only the relevant subset in a dedicated PR.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In @.gitignore around lines 116 - 574, Revert the large unrelated addition in
.gitignore (the block that added Visual Studio/PlatformIO patterns such as the
VisualStudio template entries and the "Naimportováno z Platfomio" section) by
removing lines that introduce patterns like __pycache__/, node_modules/,
interface/src/i18n/, src/ESP32React/WWWData.h, sdkconfig.*, CMakeLists.txt,
[Ll]og/, artifacts/, and other .NET/MSBuild/NuGet/PlatformIO-specific rules (the
entire insertion between the Visual Studio template start and the PlatformIO
footer). Remove any duplicate patterns introduced (e.g., __pycache__/,
node_modules/, build/, dist/, venv/, .DS_Store) so the file only contains
patterns relevant to this Python Home Assistant integration; if any of the
removed patterns are genuinely needed, add a minimal, focused subset in a
separate PR referencing those specific patterns.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Error in log: Validation of translation placeholders for localized (cs) string #1189
Motivation and Context
How has this been tested?
Several restarts of the HA. The error didn't appear in the logs anymore.
Screenshots (if appropriate):
Types of changes
Checklist