Rename microgrid.components -> microgrid.electrical_components #291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
part:protobuf
tar-viturawong-frequenz
force-pushed
the
refactor/rename-electrical-components
branch
from
ea3cfce to
913a6e1
Compare
Signed-off-by: Tar Viturawong <[email protected]>
tar-viturawong-frequenz
force-pushed
the
refactor/rename-electrical-components
branch
from
913a6e1 to
ff1d341
Compare
Contributor
|
Thanks @tar-viturawong-frequenz. Could you please add an entry to the RELEASE_NOTES file as well? |
Contributor
tiyash-basu-frequenz
left a comment
tiyash-basu-frequenz
left a comment
There was a problem hiding this comment.
A release note entry would be great.
proto/frequenz/api/common/v1/microgrid/electrical_components/electrical_components.proto
Outdated
Show resolved
Hide resolved
…lectrical_components.proto Co-authored-by: Tiyash Basu <[email protected]> Signed-off-by: Tar Viturawong <[email protected]>
Signed-off-by: Tar Viturawong <[email protected]>
Signed-off-by: Tar Viturawong <[email protected]>
llucax
reviewed
Apr 1, 2025
Contributor
llucax
left a comment
llucax
left a comment
There was a problem hiding this comment.
The CI is failing here because you are missing a rename of py/frequenz/api/common/v1/microgrid/components to electrical_components too.
| """Test that the modules can be imported.""" | ||
| # pylint: disable=import-outside-toplevel | ||
| from frequenz.api.common.v1.microgrid import components | ||
| from frequenz.api.common.v1.microgrid import electrical_components |
Contributor
There was a problem hiding this comment.
It is really weird that these tests don't fail too, but I guess this is for a separate investigation/PR.
Signed-off-by: Tar Viturawong <[email protected]>
tiyash-basu-frequenz
approved these changes
Apr 1, 2025
tar-viturawong-frequenz
deleted the
refactor/rename-electrical-components
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is in preparation for communication components to just the protobuf definition. The PR disambiguates electrical components by adding
Electricalprefix to message/enum types,electrical_to module and path names, andELECTRICAL_to enum fields.I have not extensively updated the comments in the protobuf definitions a that would have created an unwieldy diff that obscures the substantive change. I can follow up on that afterwards.