Skip to content

Rename microgrid.components -> microgrid.electrical_components #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 1, 2025
Merged

Rename microgrid.components -> microgrid.electrical_components #291

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ff1d341
Rename microgrid.components -> microgrid.electrical_components
tar-viturawong-frequenz Mar 27, 2025
dc319e9
Update proto/frequenz/api/common/v1/microgrid/electrical_components/e…
tar-viturawong-frequenz Mar 31, 2025
30e4c7c
Update RELEASE_NOTES.md
tar-viturawong-frequenz Mar 31, 2025
2dfc2f2
Make protolint happy
tar-viturawong-frequenz Mar 31, 2025
26b8b93
Move py module components -> electrical_components
tar-viturawong-frequenz Apr 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...mon/v1/microgrid/components/battery.proto → ...ogrid/electrical_components/battery.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

syntax = "proto3";

package frequenz.api.common.v1.microgrid.components;
package frequenz.api.common.v1.microgrid.electrical_components;

// Enumerated battery types.
enum BatteryType {
Expand Down
222 changes: 111 additions & 111 deletions .../v1/microgrid/components/components.proto → ...al_components/electrical_components.proto
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion .../v1/microgrid/components/ev_charger.proto → ...id/electrical_components/ev_charger.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

syntax = "proto3";

package frequenz.api.common.v1.microgrid.components;
package frequenz.api.common.v1.microgrid.electrical_components;

// Enumerated EV charger types.
enum EvChargerType {
Expand Down
2 changes: 1 addition & 1 deletion ...common/v1/microgrid/components/fuse.proto → ...icrogrid/electrical_components/fuse.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

syntax = "proto3";

package frequenz.api.common.v1.microgrid.components;
package frequenz.api.common.v1.microgrid.electrical_components;

// A representation of a fuse.
// The fuse component represents a fuse in the microgrid. It is used to protect
Expand Down
2 changes: 1 addition & 1 deletion ...common/v1/microgrid/components/grid.proto → ...icrogrid/electrical_components/grid.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

syntax = "proto3";

package frequenz.api.common.v1.microgrid.components;
package frequenz.api.common.v1.microgrid.electrical_components;

// A representation of a grid connection point. This is the point where a
// microgrid connects to the grid.
Expand Down
2 changes: 1 addition & 1 deletion ...on/v1/microgrid/components/inverter.proto → ...grid/electrical_components/inverter.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

syntax = "proto3";

package frequenz.api.common.v1.microgrid.components;
package frequenz.api.common.v1.microgrid.electrical_components;

// Enumerated inverter types.
enum InverterType {
Expand Down
2 changes: 1 addition & 1 deletion ...v1/microgrid/components/transformer.proto → ...d/electrical_components/transformer.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

syntax = "proto3";

package frequenz.api.common.v1.microgrid.components;
package frequenz.api.common.v1.microgrid.electrical_components;

// A representation of a voltage transformer.
// Voltage transformers are used to step up or step down the voltage, keeping
Expand Down
46 changes: 27 additions & 19 deletions pytests/test_common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,80 +103,88 @@ def test_module_import_microgrid_lifetime() -> None:
assert lifetime_pb2_grpc is not None


def test_module_import_microgrid_components() -> None:
def test_module_import_microgrid_electrical_components() -> None:
"""Test that the modules can be imported."""
# pylint: disable=import-outside-toplevel
from frequenz.api.common.v1.microgrid import components
from frequenz.api.common.v1.microgrid import electrical_components
Copy link
Contributor

@llucax llucax Apr 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is really weird that these tests don't fail too, but I guess this is for a separate investigation/PR.


assert components is not None
assert electrical_components is not None

# pylint: disable=import-outside-toplevel
from frequenz.api.common.v1.microgrid.components import battery_pb2
from frequenz.api.common.v1.microgrid.electrical_components import battery_pb2

assert battery_pb2 is not None

# pylint: disable=import-outside-toplevel
from frequenz.api.common.v1.microgrid.components import battery_pb2_grpc
from frequenz.api.common.v1.microgrid.electrical_components import battery_pb2_grpc

assert battery_pb2_grpc is not None

# pylint: disable=import-outside-toplevel
from frequenz.api.common.v1.microgrid.components import components_pb2
from frequenz.api.common.v1.microgrid.electrical_components import (
electrical_components_pb2,
)

assert components_pb2 is not None
assert electrical_components_pb2 is not None

# pylint: disable=import-outside-toplevel
from frequenz.api.common.v1.microgrid.components import components_pb2_grpc
from frequenz.api.common.v1.microgrid.electrical_components import (
electrical_components_pb2_grpc,
)

assert components_pb2_grpc is not None
assert electrical_components_pb2_grpc is not None

# pylint: disable=import-outside-toplevel
from frequenz.api.common.v1.microgrid.components import ev_charger_pb2
from frequenz.api.common.v1.microgrid.electrical_components import ev_charger_pb2

assert ev_charger_pb2 is not None

# pylint: disable=import-outside-toplevel
from frequenz.api.common.v1.microgrid.components import ev_charger_pb2_grpc
from frequenz.api.common.v1.microgrid.electrical_components import (
ev_charger_pb2_grpc,
)

assert ev_charger_pb2_grpc is not None

# pylint: disable=import-outside-toplevel
from frequenz.api.common.v1.microgrid.components import fuse_pb2
from frequenz.api.common.v1.microgrid.electrical_components import fuse_pb2

assert fuse_pb2 is not None

# pylint: disable=import-outside-toplevel
from frequenz.api.common.v1.microgrid.components import fuse_pb2_grpc
from frequenz.api.common.v1.microgrid.electrical_components import fuse_pb2_grpc

assert fuse_pb2_grpc is not None

# pylint: disable=import-outside-toplevel
from frequenz.api.common.v1.microgrid.components import grid_pb2
from frequenz.api.common.v1.microgrid.electrical_components import grid_pb2

assert grid_pb2 is not None

# pylint: disable=import-outside-toplevel
from frequenz.api.common.v1.microgrid.components import grid_pb2_grpc
from frequenz.api.common.v1.microgrid.electrical_components import grid_pb2_grpc

assert grid_pb2_grpc is not None

# pylint: disable=import-outside-toplevel
from frequenz.api.common.v1.microgrid.components import inverter_pb2
from frequenz.api.common.v1.microgrid.electrical_components import inverter_pb2

assert inverter_pb2 is not None

# pylint: disable=import-outside-toplevel
from frequenz.api.common.v1.microgrid.components import inverter_pb2_grpc
from frequenz.api.common.v1.microgrid.electrical_components import inverter_pb2_grpc

assert inverter_pb2_grpc is not None

# pylint: disable=import-outside-toplevel
from frequenz.api.common.v1.microgrid.components import transformer_pb2
from frequenz.api.common.v1.microgrid.electrical_components import transformer_pb2

assert transformer_pb2 is not None

# pylint: disable=import-outside-toplevel
from frequenz.api.common.v1.microgrid.components import transformer_pb2_grpc
from frequenz.api.common.v1.microgrid.electrical_components import (
transformer_pb2_grpc,
)

assert transformer_pb2_grpc is not None

Expand Down