-
Notifications
You must be signed in to change notification settings - Fork 14
Add new message definitions for streaming events #294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
ee1a7b7 to
0a4a735
Compare
04119f8 to
f4741be
Compare
llucax
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if anyone else with a broader overview of the APIs needs to approve, but LGTM.
|
(removing auto-merge in case someone else that plans to use should approve, if not feel free to re-queue for merging) |
|
(rebased) will wait till Monday then I'll merge it |
thomas-nicolai-frequenz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Mathias L. Baumann <[email protected]>
refs frequenz-floss/frequenz-api-dispatch#231
refs https://github.com/frequenz-io/frequenz-api-hostconfig/issues/4
fyi @tar-viturawong-frequenz