Skip to content

Conversation

@Marenz
Copy link
Contributor

@Marenz Marenz commented Apr 2, 2025

@Marenz Marenz requested a review from a team as a code owner April 2, 2025 15:23
@Marenz Marenz requested a review from ktickner April 2, 2025 15:23
@github-actions github-actions bot added part:docs Affects the documentation part:protobuf Affects the protocol buffer definition files labels Apr 2, 2025
@Marenz
Copy link
Contributor Author

Marenz commented Apr 3, 2025

Depends on #295

@Marenz Marenz force-pushed the eventufl branch 3 times, most recently from ee1a7b7 to 0a4a735 Compare April 9, 2025 12:24
@github-actions github-actions bot added the part:tooling Affects the development tooling (CI, deployment, dependency management, etc.) label Apr 28, 2025
@Marenz Marenz force-pushed the eventufl branch 2 times, most recently from 04119f8 to f4741be Compare April 28, 2025 08:16
@github-actions github-actions bot added the part:python Affects the Python bindings label Apr 28, 2025
@Marenz Marenz enabled auto-merge April 28, 2025 08:28
@Marenz Marenz requested a review from llucax April 28, 2025 08:36
llucax
llucax previously approved these changes Apr 30, 2025
Copy link
Contributor

@llucax llucax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if anyone else with a broader overview of the APIs needs to approve, but LGTM.

@Marenz Marenz added this pull request to the merge queue Apr 30, 2025
@llucax llucax removed this pull request from the merge queue due to a manual request Apr 30, 2025
@llucax
Copy link
Contributor

llucax commented Apr 30, 2025

(removing auto-merge in case someone else that plans to use should approve, if not feel free to re-queue for merging)

@Marenz
Copy link
Contributor Author

Marenz commented Apr 30, 2025

(rebased) will wait till Monday then I'll merge it

@llucax
Copy link
Contributor

llucax commented May 5, 2025

FYI @thomas-nicolai-frequenz

Copy link
Contributor

@thomas-nicolai-frequenz thomas-nicolai-frequenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Marenz Marenz merged commit 6e1c00e into frequenz-floss:v0.x.x May 5, 2025
6 checks passed
@Marenz Marenz deleted the eventufl branch May 5, 2025 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

part:docs Affects the documentation part:protobuf Affects the protocol buffer definition files part:python Affects the Python bindings part:tooling Affects the development tooling (CI, deployment, dependency management, etc.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants