Add enum ElectricalComponentControlMode
#307
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
part:protobuf
Contributor
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
proto/frequenz/api/common/v1/microgrid/electrical_components/electrical_components.proto:126
- Consider replacing 'upstream' with 'downstream' for consistency with the PR description and to avoid confusion about the intended audience for the component's availability.
// component availability to upstream services and applications.
proto/frequenz/api/common/v1/microgrid/electrical_components/electrical_components.proto
Outdated
Show resolved
Hide resolved
tiyash-basu-frequenz
force-pushed
the
elec_control_mode
branch
3 times, most recently
from
2fbcdf0 to
d44aa3b
Compare
proto/frequenz/api/common/v1/microgrid/electrical_components/electrical_components.proto
Show resolved
Hide resolved
proto/frequenz/api/common/v1/microgrid/electrical_components/electrical_components.proto
Outdated
Show resolved
Hide resolved
proto/frequenz/api/common/v1/microgrid/electrical_components/electrical_components.proto
Outdated
Show resolved
Hide resolved
| // !!! example "Control Mode Change Impact" | ||
| // If a battery component's Control Mode is switched from ACTIVE to | ||
| // INACTIVE, it immediately becomes unavailable to downstream | ||
| // energy-management services, potentially disrupting scheduled |
Contributor
There was a problem hiding this comment.
Lets remove the "energy-management" part and just say "services and agents".
tiyash-basu-frequenz
force-pushed
the
elec_control_mode
branch
from
a3a3656 to
d23b50a
Compare
thomas-nicolai-frequenz
previously approved these changes
Apr 8, 2025
This enum is used to explicitly define whether an electrical component is intended to be active (enabled) or inactive (disabled). This intention directly determines the component's availability to downstream services and applications. Note that this enum differs from the `ElectricalComponentStatus` enum, which is used to report the actual operational state of the component. Signed-off-by: Tiyash Basu <[email protected]> # Conflicts: # RELEASE_NOTES.md # proto/frequenz/api/common/v1/microgrid/electrical_components/electrical_components.proto
The `ElectricalComponentStatus` enum has been removed in favour of the `ElectricalComponentControlMode` enum. Signed-off-by: Tiyash Basu <[email protected]> # Conflicts: # proto/frequenz/api/common/v1/microgrid/electrical_components/electrical_components.proto
tiyash-basu-frequenz
dismissed
thomas-nicolai-frequenz’s stale review
via
49ac745
tiyash-basu-frequenz
force-pushed
the
elec_control_mode
branch
from
d23b50a to
49ac745
Compare
llucax
approved these changes
May 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enum is used to explicitly define whether an electrical component is intended to be active (enabled) or inactive (disabled). This intention directly determines the component's availability to downstream services and applications.
Note that this enum differs from the
ElectricalComponentStatusenum, which is used to report the actual operational state of the component.Thanks to @thomas-nicolai-frequenz for providing the original version.