Fix outdated documentation #332
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tiyash Basu <[email protected]>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the outdated documentation in two proto files to reflect the correct field name for vendor-specific diagnostics.
- Updated "vendorErrorCode" to "vendorDiagnosticCode" in electrical_components.proto.
- Updated "vendorErrorCode" to "vendorDiagnosticCode" in communication_components.proto.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| proto/frequenz/api/common/v1/microgrid/electrical_components/electrical_components.proto | Updated vendor field naming in documentation |
| proto/frequenz/api/common/v1/microgrid/communication_components/communication_components.proto | Updated vendor field naming in documentation |
github-actions
bot
added
the
part:protobuf
tiyash-basu-frequenz
added
cmd:skip-release-notes
llucax
approved these changes
May 16, 2025
Merged
via the queue into
frequenz-floss:v0.x.x
with commit May 19, 2025
ca51019
7 of 8 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.