Skip to content

Rename category type field in ElectricalComponent #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 20, 2025
Merged

Rename category type field in ElectricalComponent #333

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions RELEASE_NOTES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@
- Renamed electrical component category `COMPONENT_CATEGORY_GRID` to `ELECTRICAL_COMPONENT_CATEGORY_GRID_CONNECTION_POINT` to clarify its meaning. Note that the change in the enum change is a part of a larger refactoring of the electrical component category enum.
- The oneof variant `ComponentCategoryMetadataVariant.metadata.grid` has been renamed to `ElectricalComponentCategorySpecificInfo.info.grid_connection_point` to better reflect its purpose.
- A new inverter type `INVERTER_TYPE_WIND_TURBINE` has been added to the `InverterType` enum.
- Renamed `ComponentCategoryMetadataVariant` to `ElectricalComponentCategorySpecificInfo`.
- Renamed field `ElectricalComponent.category_type` to `ElectricalComponent.category_specific_info` to better reflect its purpose.

## Bug Fixes

Expand Down
6 changes: 3 additions & 3 deletions proto/frequenz/api/common/v1/microgrid/electrical_components/electrical_components.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,8 +349,8 @@ message MetricConfigBounds {
}

// Metadata specific to a microgrid component.
message ElectricalComponentCategoryMetadataVariant {
oneof metadata {
message ElectricalComponentCategorySpecificInfo {
oneof kind {
frequenz.api.common.v1.microgrid.electrical_components.Battery battery = 1;
frequenz.api.common.v1.microgrid.electrical_components.EvCharger
ev_charger = 2;
Expand Down Expand Up @@ -379,7 +379,7 @@ message ElectricalComponent {
ElectricalComponentCategory category = 4;

// The metadata specific to the component category type.
ElectricalComponentCategoryMetadataVariant category_type = 5;
ElectricalComponentCategorySpecificInfo category_specific_info = 5;

// The component manufacturer.
string manufacturer = 6;
Expand Down
Loading