Skip to content

Rename metric_sample.proto to metrics.proto #338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 20, 2025
Merged

Rename metric_sample.proto to metrics.proto #338

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions RELEASE_NOTES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
- Remove unnecessary gap in numbering in the `ElectricalComponentCategory` enum.
- Renumber variants in the `Metric` enum to remove unnecessary gaps.
- Added a new enum `ElectricalComponentControlMode` to define control modes for electrical components.
- Renamed `metric_sample.proto` to `metrics.proto` to better reflect its content.

## Bug Fixes

Expand Down
0 ...api/common/v1/metrics/metric_sample.proto → ...quenz/api/common/v1/metrics/metrics.proto
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion proto/frequenz/api/common/v1/microgrid/electrical_components/electrical_components.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ syntax = "proto3";
package frequenz.api.common.v1.microgrid.electrical_components;

import "frequenz/api/common/v1/metrics/bounds.proto";
import "frequenz/api/common/v1/metrics/metric_sample.proto";
import "frequenz/api/common/v1/metrics/metrics.proto";
import "frequenz/api/common/v1/microgrid/electrical_components/battery.proto";
import
"frequenz/api/common/v1/microgrid/electrical_components/ev_charger.proto";
Expand Down
2 changes: 1 addition & 1 deletion proto/frequenz/api/common/v1/microgrid/sensors/sensors.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ syntax = "proto3";

package frequenz.api.common.v1.microgrid.sensors;

import "frequenz/api/common/v1/metrics/metric_sample.proto";
import "frequenz/api/common/v1/metrics/metrics.proto";
import "frequenz/api/common/v1/microgrid/lifetime.proto";

import "google/protobuf/timestamp.proto";
Expand Down
10 changes: 5 additions & 5 deletions pytests/test_common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,17 +38,17 @@ def test_module_import_metrics_bounds() -> None:
assert bounds_pb2_grpc is not None


def test_module_import_metrics_metric_sample() -> None:
def test_module_import_metrics_metrics() -> None:
"""Test that the modules can be imported."""
# pylint: disable=import-outside-toplevel
from frequenz.api.common.v1.metrics import metric_sample_pb2
from frequenz.api.common.v1.metrics import metrics_pb2

assert metric_sample_pb2 is not None
assert metrics_pb2 is not None

# pylint: disable=import-outside-toplevel
from frequenz.api.common.v1.metrics import metric_sample_pb2_grpc
from frequenz.api.common.v1.metrics import metrics_pb2_grpc

assert metric_sample_pb2_grpc is not None
assert metrics_pb2_grpc is not None


def test_module_import_grid() -> None:
Expand Down
Loading