Fix typo in field name in CommunicationComponentDiagnostic
#340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The field name `vendor_error_code` in the `CommunicationComponentDiagnostic` message was incorrectly named, since it is not an error code but a more general diagnostic code. This commit renames the field to `vendor_diagnostic_code` to better reflect its purpose. Signed-off-by: Tiyash Basu <[email protected]>
tiyash-basu-frequenz
added
type:bug
github-actions
bot
added
the
part:protobuf
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a naming error in the CommunicationComponentDiagnostic message by renaming the field from vendor_error_code to vendor_diagnostic_code.
- Renames the field to better reflect its purpose.
- Updates the associated inline comment to remove the "error" terminology.
tiyash-basu-frequenz
added
the
cmd:skip-release-notes
llucax
approved these changes
May 20, 2025
Merged
via the queue into
frequenz-floss:v0.x.x
with commit May 20, 2025
9495123
6 of 9 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The field name
vendor_error_codein theCommunicationComponentDiagnosticmessage was incorrectly named, since it is not an error code but a more general diagnostic code. This commit renames the field tovendor_diagnostic_codeto better reflect its purpose.closes #330