Skip to content

Remove SensorMetricSample in favour of MetricSample #346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 22, 2025
Merged

Remove SensorMetricSample in favour of MetricSample #346

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a0ca00
Remove `SensorMetricSample` in favour of `MetricSample`
tiyash-basu-frequenz May 22, 2025
3567a48
Remove unused enum `SensorMetric`
tiyash-basu-frequenz May 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions RELEASE_NOTES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
- Renamed `SensorState` to `SensorStateSnapshot` to better reflect its purpose.
- Renamed `sampled_at` timestamps for state snapshots to `origin_time`.
- Renamed `sampled_at` timestamps for metric samples to `sample_time`.
- Remove `SensorMetricSample` in favour of using `MetricSample` for sensors.

## Bug Fixes

Expand Down
6 changes: 5 additions & 1 deletion proto/frequenz/api/common/v1/microgrid/sensors/sensors.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,11 +233,15 @@ message SensorMetricSample {
// sample_time: "2023-10-01T00:00:00Z",
// metric: "METRIC_SENSOR_TEMPERATURE",
// value: metric_value_variant: {simple_metric: {value: 23.5},
// bounds: {}
// source: {}
// },
// {
// sample_time: "2023-10-01T00:00:00Z",
// metric: "METRIC_SENSOR_RELATIVE_HUMIDITY",
// value: metric_value_variant: {simple_metric: {value: 23.5},
// bounds: {}
// source: "humidity_sensor_1"
// }
// ],
// states: [
Expand All @@ -254,7 +258,7 @@ message SensorData {
uint64 sensor_id = 1;

// List of measurements for a metric of the specific microgrid sensor.
repeated SensorMetricSample metric_samples = 2;
repeated frequenz.api.common.v1.metrics.MetricSample metric_samples = 2;

// List of states of a specific microgrid sensor.
repeated SensorStateSnapshot states = 3;
Expand Down
Loading