Skip to content

Rename SensorStateCode variant ON to OK in sensors.proto #350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2025
Merged

Rename SensorStateCode variant ON to OK in sensors.proto #350

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions RELEASE_NOTES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@
- Remove `SensorMetricSample` in favour of using `MetricSample` for sensors.
- Remove `SensorMetric` enum, since it was unused and redundant.
- Renamed `MetricSample.source` to `MetricSample.connection` to make it more specific as to what it refers to.
- Rename `SensorStateCode.SENSOR_STATE_CODE_ON` to `SensorStateCode.SENSOR_STATE_CODE_OK`, to better indicate that we do not control on/off state of sensors.

## Bug Fixes

Expand Down
2 changes: 1 addition & 1 deletion proto/frequenz/api/common/v1/microgrid/sensors/sensors.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ enum SensorStateCode {
SENSOR_STATE_CODE_UNSPECIFIED = 0;

// The sensor is up and running.
SENSOR_STATE_CODE_ON = 1;
SENSOR_STATE_CODE_OK = 1;

// The sensor is in an error state.
SENSOR_STATE_CODE_ERROR = 2;
Expand Down
Loading