docs: clarify meaning of control_mode in ElectricalComponent #358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the applied control mode, not the requested control mode. Signed-off-by: Tar Viturawong <[email protected]>
github-actions
bot
added
the
part:protobuf
Signed-off-by: Tar Viturawong <[email protected]>
tiyash-basu-frequenz
requested changes
Jun 3, 2025
proto/frequenz/api/common/v1/microgrid/electrical_components/electrical_components.proto
Show resolved
Hide resolved
Contributor
tiyash-basu-frequenz
left a comment
tiyash-basu-frequenz
left a comment
There was a problem hiding this comment.
The change I previously suggested is not relevant anymore. But we have other changes planned.
Contributor
Author
|
We have decided not to include |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the applied control mode, not the requested control mode.