Skip to content

Change vendor diagnostic codes to string type #362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2025
Merged

Change vendor diagnostic codes to string type #362

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .../frequenz/api/common/v1/microgrid/communication_components/communication_components.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ message CommunicationComponent {
// ```json
// {
// "diagnosticCode": "COMMUNICATION_COMPONENT_DIAGNOSTIC_CODE_CONFIGURATION_ERR",
// "vendorDiagnosticCode": 1002,
// "vendorDiagnosticCode": "ERR_1002",
// "message": "VLAN mismatch detected on port 3"
// }
// ```
Expand All @@ -160,7 +160,7 @@ message CommunicationComponentDiagnostic {
CommunicationComponentDiagnosticCode diagnostic_code = 1;

// Optional vendor-provided code for more granular diagnostics.
optional uint32 vendor_diagnostic_code = 2;
optional string vendor_diagnostic_code = 2;

// Human-readable message providing additional context.
string message = 3;
Expand Down
4 changes: 2 additions & 2 deletions proto/frequenz/api/common/v1/microgrid/electrical_components/electrical_components.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -464,7 +464,7 @@ message ElectricalComponentConnection {
// {
// "diagnosticCode":
// "ELECTRICAL_COMPONENT_DIAGNOSTIC_CODE_OVERTEMPERATURE",
// "vendorDiagnosticCode": 2003,
// "vendorDiagnosticCode": "2003",
// "message": "Temperature sensor 3 reported 61.5°C (limit: 60°C)"
// }
// ```
Expand All @@ -485,7 +485,7 @@ message ElectricalComponentDiagnostic {

// Optional vendor-provided error code for the error, for vendor-specific
// insights or more granular diagnostics.
optional uint32 vendor_diagnostic_code = 2;
optional string vendor_diagnostic_code = 2;

// Optional human-readable message providing additional context.
string message = 3;
Expand Down
4 changes: 2 additions & 2 deletions proto/frequenz/api/common/v1/microgrid/sensors/sensors.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ message Sensor {
// {
// "diagnosticCode":
// "SENSOR_DIAGNOSTIC_CODE_INTERNAL",
// "vendorErrorCode": 2003,
// "vendorErrorCode": "2003",
// "message": "Temperature sensor 3 reported 61.5°C (limit: 60°C)"
// }
// ```
Expand All @@ -91,7 +91,7 @@ message SensorDiagnostic {

// Optional vendor-provided diagnostic code for the error, for vendor-specific
// insights or more granular diagnostics.
optional uint32 vendor_diagnostic_code = 2;
optional string vendor_diagnostic_code = 2;

// Optional human-readable message providing additional context.
string message = 3;
Expand Down
Loading