Rename INVERTER_TYPE_SOLAR to INVERTER_TYPE_PHOTOVOLTAIC
#373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit renames the enum variant `InverterType.INVERTER_TYPE_SOLAR` to `InverterType.INVERTER_TYPE_PHOTOVOLTAIC` in the `inverter.proto` file. This change is made to align with the more colloquial term "PV inverter", while avoiding the use of an abbreviation. Signed-off-by: Tiyash Basu <[email protected]>
tiyash-basu-frequenz
added
the
type:enhancement
github-actions
bot
added
part:docs
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR renames the enum variant from INVERTER_TYPE_SOLAR to INVERTER_TYPE_PHOTOVOLTAIC to align with the preferred terminology for photovoltaic inverters.
- Renames the enum variant in the proto file and updates its accompanying comment.
- Updates the corresponding reference in the release notes to reflect the new enum name.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| proto/frequenz/api/common/v1/microgrid/electrical_components/inverter.proto | Renamed enum variant and updated its comment |
| RELEASE_NOTES.md | Updated release notes to reflect the new enum name |
Comments suppressed due to low confidence (2)
proto/frequenz/api/common/v1/microgrid/electrical_components/inverter.proto:21
- [nitpick] The updated comment includes the abbreviation 'PV', which contradicts the commit description's goal of avoiding abbreviations. Consider removing '(PV)' to maintain consistency.
// Photovoltaic (PV) inverter.
RELEASE_NOTES.md:36
- [nitpick] The release notes mention 'PV inverter' despite the intention to avoid abbreviations as stated in the commit description. Consider revising the comment for consistency.
* `InverterType.INVERTER_TYPE_SOLAR` to `InverterType.INVERTER_TYPE_PHOTOVOLTAIC` (to align with the more colloquial term "PV inverter", but without using abbreviations)
This was referenced Jun 13, 2025
llucax
approved these changes
Jun 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit renames the enum variant
InverterType.INVERTER_TYPE_SOLARtoInverterType.INVERTER_TYPE_PHOTOVOLTAICin theinverter.protofile. This change is made to align with the more colloquial term "PV inverter", while avoiding the use of an abbreviation.