Override the default include path when generating protobuf files #375
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
part:tooling
Contributor
Author
|
Draft because it depends on the |
llucax
force-pushed
the
fix-proto-include-paths
branch
from
9ea4506 to
19a5bf7
Compare
By default `repo-config` will include the `submodules/frequenz-api-common` directory, which is us, and we don't want to include ourselves as a submodule, so we need to explicitly set the `include_paths` to an empty array. We also need to bump the dependency on `frequenz-repo-config` to get a bug fix that allows overriding with an empty array. Signed-off-by: Leandro Lucarella <[email protected]>
llucax
force-pushed
the
fix-proto-include-paths
branch
from
19a5bf7 to
c76bca2
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR overrides the default include path for protobuf generation by explicitly setting the include_paths to an empty array and bumps the dependency version of frequence-repo-config to 0.13.5 to include a bug fix.
- Bumped frequence-repo-config[api] version from 0.13.4 to 0.13.5 in multiple dependency blocks.
- Added a new [tool.frequenz-repo-config.protobuf] section with include_paths set to an empty array to avoid including the submodule.
Contributor
Author
|
Ready for review. |
tiyash-basu-frequenz
approved these changes
Jun 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default
repo-configwill include thesubmodules/frequenz-api-commondirectory, which is us, and we don't want to include ourselves as a submodule, so we need to explicitly set theinclude_pathsto an empty array.We also need to bump the dependency on
frequenz-repo-configto get a bug fix that allows overriding with an empty array.