Extend the ElectricalComponentCategory enum with new variants
#378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
part:docs
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR extends and reorganizes the ElectricalComponentCategory enum, adding new variants while renumbering existing ones and renaming one variant for clearer alignment with industry terminology.
- Renumbers enum variants
- Adds six new variants to the enum
- Renames the RELAY variant to BREAKER
- Updates documentation in RELEASE_NOTES.md to reflect the changes
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| proto/frequenz/api/common/v1alpha7/microgrid/electrical_components/electrical_components.proto | Updated enum definition with new variants, renumbering, and a renaming of the relay variant to breaker |
| RELEASE_NOTES.md | Updated release notes with the new enum name and variant changes |
proto/frequenz/api/common/v1alpha7/microgrid/electrical_components/electrical_components.proto
Outdated
Show resolved
Hide resolved
tiyash-basu-frequenz
force-pushed
the
electrical_components
branch
2 times, most recently
from
24a015f to
955ce0b
Compare
llucax
previously approved these changes
Jun 17, 2025
Contributor
llucax
left a comment
llucax
left a comment
There was a problem hiding this comment.
LGTM, if it is not too much work I would split the changes only improving docs in a separate commit, but if you are very busy I'm also good to merge as is.
tiyash-basu-frequenz
dismissed stale reviews from thomas-nicolai-frequenz and llucax
via
2ea4bf7
tiyash-basu-frequenz
force-pushed
the
electrical_components
branch
from
955ce0b to
2ea4bf7
Compare
Signed-off-by: Tiyash Basu <[email protected]> This commit - renumbers the variants in the `ElectricalComponentCategory` enum. - adds new variants to the `ElectricalComponentCategory` enum: - `ELECTRICAL_COMPONENT_CATEGORY_PLC` - `ELECTRICAL_COMPONENT_CATEGORY_STATIC_TRANSFER_SWITCH` - `ELECTRICAL_COMPONENT_CATEGORY_UNINTERRUPTIBLE_POWER_SUPPLY` - `ELECTRICAL_COMPONENT_CATEGORY_CAPACITOR_BANK` - `ELECTRICAL_COMPONENT_CATEGORY_SMART_LOAD` - `ELECTRICAL_COMPONENT_CATEGORY_WIND_TURBINE` - Renames the variant `ELECTRICAL_COMPONENT_CATEGORY_RELAY` to `ELECTRICAL_COMPONENT_CATEGORY_BREAKER` to better align with the common terminology used in electrical engineering.
tiyash-basu-frequenz
force-pushed
the
electrical_components
branch
from
2ea4bf7 to
940c1c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
ElectricalComponentCategoryenum.ElectricalComponentCategoryenum:ELECTRICAL_COMPONENT_CATEGORY_PLCELECTRICAL_COMPONENT_CATEGORY_STATIC_TRANSFER_SWITCHELECTRICAL_COMPONENT_CATEGORY_UNINTERRUPTIBLE_POWER_SUPPLYELECTRICAL_COMPONENT_CATEGORY_CAPACITOR_BANKELECTRICAL_COMPONENT_CATEGORY_SMART_LOADELECTRICAL_COMPONENT_CATEGORY_WIND_TURBINEELECTRICAL_COMPONENT_CATEGORY_RELAYtoELECTRICAL_COMPONENT_CATEGORY_BREAKERto better align with the common terminology used in electrical engineering.