Move all electrical component types to a single file #380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
part:docs
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR consolidates all electrical component types into a single proto file (electrical_components.proto) to simplify maintenance and usage across the codebase.
- Merges definitions for Battery, EvCharger, Fuse, Inverter, GridConnectionPoint, and VoltageTransformer into electrical_components.proto.
- Updates tests to use the consolidated definitions and removes individual import statements from their original files.
- Removes the obsolete proto files for each individual component and updates the release notes accordingly.
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pytests/test_common_v1alpha7.py | Updated test imports to reference the consolidated electrical_components.proto definitions. |
| transformer.proto, inverter.proto, grid.proto, fuse.proto, ev_charger.proto, battery.proto | Removed individual proto files containing electrical component definitions. |
| electrical_components.proto | Contains the consolidated definitions for all electrical components. |
| RELEASE_NOTES.md | Updated release notes to document the move of electrical component definitions. |
tiyash-basu-frequenz
force-pushed
the
377_elec_component_types
branch
from
dfaa792 to
d06b331
Compare
shsms
previously approved these changes
Jun 19, 2025
shsms
reviewed
Jun 19, 2025
This commit moves all the electrical component types from their individual files into `electrical_components.proto`. Signed-off-by: Tiyash Basu <[email protected]>
tiyash-basu-frequenz
force-pushed
the
377_elec_component_types
branch
from
d06b331 to
3cd4856
Compare
shsms
approved these changes
Jun 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit moves all the electrical component types from their individual files into
electrical_components.proto.closes #377