Remove InverterType.INVERTER_TYPE_WIND_TURBINE
#397
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wind turbines typically do AC->DC->AC conversion, so classifying them as inverters is not appropriate. Additionally, a component category `COMPONENT_CATEGORY_WIND_TURBINE` already exists to represent wind turbines, so it is redundant to have a separate inverter type for them. Signed-off-by: Tiyash Basu <[email protected]>
github-actions
bot
added
part:docs
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the INVERTER_TYPE_WIND_TURBINE enum value from InverterType since wind turbines already have their own component category, and it updates the release notes accordingly.
- Drop redundant
INVERTER_TYPE_WIND_TURBINEentry from the proto enum - Add a release-note entry for the removal
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| proto/frequenz/api/common/v1alpha8/microgrid/electrical_components/electrical_components.proto | Removed the wind-turbine inverter enum entry |
| RELEASE_NOTES.md | Documented the enum value removal in release notes |
Comments suppressed due to low confidence (1)
proto/frequenz/api/common/v1alpha8/microgrid/electrical_components/electrical_components.proto:529
- After removing an enum value, protobuf best practices recommend reserving its numeric tag to prevent future reuse—e.g., add
reserved 4;above the closing brace.
}
tar-viturawong-frequenz
approved these changes
Jul 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wind turbines typically do AC->DC->AC conversion, so classifying them as inverters is not appropriate. Additionally, a component category
COMPONENT_CATEGORY_WIND_TURBINEalready exists to represent wind turbines, so it is redundant to have a separate inverter type for them.