Rename voltage-transformer to power-transformer #399
Conversation
github-actions
bot
added
part:docs
There was a problem hiding this comment.
Pull Request Overview
Renames all occurrences of "voltage transformer" to "power transformer" to better reflect the component's role in bulk energy transfer.
- Updated enum value and documentation in
electrical_components.proto - Renamed
VoltageTransformermessage toPowerTransformerand updated the corresponding field inElectricalComponentCategorySpecificInfo - Added entries to
RELEASE_NOTES.mdto document the renaming
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| proto/frequenz/api/common/v1alpha8/microgrid/electrical_components/electrical_components.proto | Renamed the enum and message from VoltageTransformer to PowerTransformer, updated comments |
| RELEASE_NOTES.md | Documented renaming of transformer identifiers in release notes |
Comments suppressed due to low confidence (1)
proto/frequenz/api/common/v1alpha8/microgrid/electrical_components/electrical_components.proto:115
- [nitpick] Consider noting that in real-world applications, output power is slightly less than input due to transformer efficiency losses, to give a more accurate technical description.
// Since power transformers try to keep the output power same as the input
llucax
left a comment
llucax
left a comment
There was a problem hiding this comment.
LGTM.
We are also using the term transformer in metrics.proto (METRIC_INVERTER_TEMPERATURE_TRANSFORMER and METRIC_CONNECTION_CATEGORY_TRANSFORMER). I guess this is s completely different concept, as it refers to the internals of a component, so it is OK that they don't match (and maybe even desirable to avoid confusion), but I thought I bring it up just in case.
Voltage-transformers are used in voltmeters for pretection, whereas what we needed was a power transformer, which is used for bulk transfer of electrical energy with voltage stepping up or down. This renaming makes the electrical component name more consistent with the underlying concept of the component. Signed-off-by: Tiyash Basu <[email protected]>
tiyash-basu-frequenz
force-pushed
the
387_voltage_power_trafop
branch
from
4ec448e to
cd954c3
Compare
|
I fixed the typo pointed out by copilot. Since the PR was otherwise approved, I'll merge it. :) |
2 participants
Voltage-transformers are used in voltmeters for pretection, whereas what we needed was a power transformer, which is used for bulk transfer of electrical energy with voltage stepping up or down.
This renaming makes the electrical component name more consistent with the underlying concept of the component.