Rename Timestamp fields to follow Protobuf guidelines #241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
part:protobuf
There was a problem hiding this comment.
Pull Request Overview
This PR renames several timestamp fields to follow Protobuf naming guidelines.
- Renames modification_time to update_time in DispatchMetadata.
- Renames from, to, and until to from_time, to_time, and until_time respectively in the TimeIntervalFilter and RecurrenceRule messages.
Comments suppressed due to low confidence (4)
proto/frequenz/api/dispatch/v1/dispatch.proto:197
- [nitpick] Consider standardizing the comment to 'UTC Timestamp' as used for create_time for consistency.
// UTC time of the last update to the order.
proto/frequenz/api/dispatch/v1/dispatch.proto:209
- [nitpick] Consider using 'UTC Timestamp' in the comment to match the style of other time fields.
// Filter by time >= this UTC time.
proto/frequenz/api/dispatch/v1/dispatch.proto:212
- [nitpick] Consider using 'UTC Timestamp' in the comment to match the style of other time fields.
// Filter by time <= this UTC time.
proto/frequenz/api/dispatch/v1/dispatch.proto:479
- [nitpick] Ensure that any associated comments for until_time are updated to maintain consistency with the revised field name.
google.protobuf.Timestamp until_time = 2;
llucax
approved these changes
Apr 22, 2025
Contributor
Author
|
@llucax hmm DCO block. I guess it's because github signed it? |
Contributor
I see DCO in green.
What is missing is the cryptographic signature (GPG or SSH) for commit.
|
- modification_time → update_time - from → from_time - to → to_time - until → until_time Aligns field names with Protobuf best practices for clarity and consistency. Signed-off-by: Mathias L. Baumann <Marenz@users.noreply.github.com>
Marenz
added a commit
to Marenz/frequenz-api-dispatch
that referenced
this pull request
Apr 24, 2025
…#241) - modification_time → update_time - from → from_time - to → to_time - until → until_time fixes frequenz-floss#240 Signed-off-by: Mathias L. Baumann <mathias.baumann@frequenz.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #240