Skip to content

Conversation

@llucax
Copy link
Contributor

@llucax llucax commented Jul 2, 2025

We need to do this because we need to manually update these to ensure the cross-version guarantees between grpcio and protobuf are respected.

We need to do this because we need to manually update these to ensure
the cross-version guarantees between grpcio and protobuf are respected.

Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
Copilot AI review requested due to automatic review settings July 2, 2025 15:03
@llucax llucax requested a review from a team as a code owner July 2, 2025 15:03
@llucax llucax self-assigned this Jul 2, 2025
@llucax llucax enabled auto-merge July 2, 2025 15:03
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the Dependabot configuration by grouping related gRPC and protobuf updates to ensure cross-version compatibility.

  • Added grpcio, grpcio-tools, and protobuf to the pip dependency allow list.
  • Introduced a new grpc group to bundle those three dependencies for coordinated updates.
Comments suppressed due to low confidence (4)

.github/dependabot.yml:39

  • The grpcio entry appears both in the top-level allow list and in the grpc group. Removing the top-level entry avoids duplication and keeps grouping clear.
          - "grpcio"

.github/dependabot.yml:40

  • The grpcio-tools entry is duplicated at top level and in the grpc group. Consider removing the top-level entry to prevent overlap.
          - "grpcio-tools"

.github/dependabot.yml:45

  • The protobuf entry is also listed under the grpc group, so it’s safe to remove the standalone entry to avoid duplication.
          - "protobuf"

.github/dependabot.yml:60

  • [nitpick] Consider renaming the group key from grpc to something more descriptive (e.g., grpc-protobuf) to match other group naming conventions and clarify its purpose.
      grpc:

@github-actions github-actions bot added the part:tooling Affects the development tooling (CI, deployment, dependency management, etc.) label Jul 2, 2025
@llucax llucax added this pull request to the merge queue Jul 28, 2025
Merged via the queue into frequenz-floss:v0.x.x with commit 18be46b Jul 28, 2025
6 checks passed
@llucax llucax deleted the grpc-group branch July 28, 2025 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

part:tooling Affects the development tooling (CI, deployment, dependency management, etc.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants