Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ email = "[email protected]"

[project.optional-dependencies]
dev-flake8 = [
"flake8 == 7.2.0",
"flake8 == 7.3.0",
"flake8-docstrings == 1.7.0",
"flake8-pyproject == 1.2.3", # For reading the flake8 config from pyproject.toml
"pydoclint == 0.6.6",
Expand All @@ -61,7 +61,7 @@ dev-mkdocs = [
"frequenz-client-base",
]
dev-mypy = [
"mypy == 1.16.1",
"mypy == 1.17.0",
"types-Markdown == 3.8.0.20250415",
"types-protobuf == 6.30.2.20250516",
"grpc-stubs == 1.53.0.6", # This dependency introduces breaking changes in patch releases
Expand All @@ -75,12 +75,12 @@ dev-pylint = [
"frequenz-client-base[dev-mkdocs,dev-noxfile,dev-pytest]",
]
dev-pytest = [
"pytest == 8.3.5",
"pytest == 8.4.1",
"frequenz-repo-config[extra-lint-examples] == 0.13.5",
"pytest-mock == 3.14.1",
"pytest-asyncio == 1.0.0",
"async-solipsism == 0.7",
"hypothesis == 6.132.0",
"hypothesis == 6.136.3",
"frequenz-client-base",
]
dev = [
Expand Down
8 changes: 1 addition & 7 deletions tests/test_client.py
Original file line number Diff line number Diff line change
Expand Up @@ -28,13 +28,7 @@ def _assert_is_disconnected(client: BaseApiClient[StubT]) -> None:
"""Assert that the client is disconnected."""
assert not client.is_connected

with pytest.raises(ClientNotConnected, match=r"") as exc_info:
_ = client.channel
exc = exc_info.value
assert exc.server_url == _DEFAULT_SERVER_URL
assert exc.operation == "channel"

with pytest.raises(ClientNotConnected, match=r"") as exc_info:
with pytest.raises(ClientNotConnected) as exc_info:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand at all how

Fix pytest warning by removing empty match parameter from pytest.raises

relates to this diff? This just removes a test case as far as I can tell.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, it didn't remove just the parameters, it removed the whole case using them

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Explained here (it was unrelated duplicated code that sneaked in accidentally):

_ = client.channel
exc = exc_info.value
assert exc.server_url == _DEFAULT_SERVER_URL
Expand Down
Loading